Thread: compiling with ssl without thread safety still broken

Compiling with ssl without thread safety still broken.

pq_initssllib is being incorrectly guarded by ENABLE_THREAD_SAFETY.

Kris Jurka

Kris Jurka <books@ejurka.com> writes:
> Compiling with ssl without thread safety still broken.
> pq_initssllib is being incorrectly guarded by ENABLE_THREAD_SAFETY.

Not to mention that it has NO business being declared at some random
place in the middle of the file.  Fix committed, but some further review
of this mare's-nest seems warranted.

This file is getting to be a poster child for the reasons not to use
#ifdefs :-(

            regards, tom lane

Tom Lane wrote:
> Kris Jurka <books@ejurka.com> writes:
> > Compiling with ssl without thread safety still broken.
> > pq_initssllib is being incorrectly guarded by ENABLE_THREAD_SAFETY.
>
> Not to mention that it has NO business being declared at some random
> place in the middle of the file.  Fix committed, but some further review
> of this mare's-nest seems warranted.

Yuck, I should have looked over this patch more closely.

> This file is getting to be a poster child for the reasons not to use
> #ifdefs :-(

Agreed.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073