Thread: Re: Updated logging config (was: Initial eventlog support on win32 )

Something about like this?

(If approved ,documentation patches of course comeing up, but I'd like
to have the syntax and ide approved before I get into that)

This patch also includes the eventlog code for win32.

//Magnus


>-----Original Message-----
>From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
>Sent: den 23 mars 2004 16:02
>To: Magnus Hagander
>Cc: Andrew Dunstan; pgsql-patches@postgresql.org
>Subject: Re: [PATCHES] Initial eventlog support on win32
>
>
>"Magnus Hagander" <mha@sollentuna.net> writes:
>> Based on what Andrew wrote, configuration along the line of:
>> log_destination        stdout
>> (for default)
>
>> log_destination        stdout,syslog
>> (for syslog=2)
>
>> log_destination        eventlog
>> (for win32 eventlog only)
>
>> etc etc.
>
>Should be "stderr" not "stdout".  Otherwise looks good.  I
>think you can
>find existing infrastructure for parsing a comma-separated list of
>keywords in a GUC variable --- look at how DateStyle is handled.
>
>            regards, tom lane
>

On 23-Mar-04, at 4:57 PM, Magnus Hagander wrote:
> Something about like this?

Looks good. One trivial gripe: you need to update psql/tab-complete.c

BTW, integrating PostgreSQL with WMI (Windows Management
Instrumentation) would be neat, I think:


http://msdn.microsoft.com/library/en-us/wmisdk/wmi/wmi_start_page.asp

-Neil

"Magnus Hagander" <mha@sollentuna.net> writes:
> Remove 'syslog' GUC variable, and add more logical 'log_destination'
> variable to control logoutput location on Unix and Win32.

I just noticed that this patch seems to have replaced a PGC_SIGHUP
config item (the syslog flag) with a PGC_POSTMASTER config item
(log_destination).  What was the reason for the downgrade in
flexibility?  If it was discussed before, I've forgotten ...

            regards, tom lane