Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

From
Tom Lane
Date:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> It seems that what we have to do for Unixware is add
>> -Kpthread to LDFLAGS; is that correct?

> Unusually, this platform doesn't have a THREAD_LIBS setting, only
> THREAD_CPPFLAGS. so I have to use that.

If Larry quoted the Compiler Guys correctly, then that is *wrong*,
and we should put -Kpthread into THREAD_LIBS.

            regards, tom lane

Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

From
Bruce Momjian
Date:
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Tom Lane wrote:
> >> It seems that what we have to do for Unixware is add
> >> -Kpthread to LDFLAGS; is that correct?
>
> > Unusually, this platform doesn't have a THREAD_LIBS setting, only
> > THREAD_CPPFLAGS. so I have to use that.
>
> If Larry quoted the Compiler Guys correctly, then that is *wrong*,
> and we should put -Kpthread into THREAD_LIBS.

Yes, his patch ended up adding this to THREAD_LIBS, but
template/unixware has:

For gcc:

  THREAD_CPPFLAGS="-pthread"

and for non-gcc:

  THREAD_CPPFLAGS="-K pthread"

Larry, are these wrong?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

From
Larry Rosenman
Date:
On Fri, 19 Mar 2004, Bruce Momjian wrote:

> Tom Lane wrote:
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > Tom Lane wrote:
> > >> It seems that what we have to do for Unixware is add
> > >> -Kpthread to LDFLAGS; is that correct?
> >
> > > Unusually, this platform doesn't have a THREAD_LIBS setting, only
> > > THREAD_CPPFLAGS. so I have to use that.
> >
> > If Larry quoted the Compiler Guys correctly, then that is *wrong*,
> > and we should put -Kpthread into THREAD_LIBS.
>
> Yes, his patch ended up adding this to THREAD_LIBS, but
> template/unixware has:
>
> For gcc:
>
>   THREAD_CPPFLAGS="-pthread"
>
> and for non-gcc:
>
>   THREAD_CPPFLAGS="-K pthread"
>
> Larry, are these wrong?
Nope, those work, and should be passed to any libpq-using programs
link step if --enable-thread-safety is used.

--
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749