Thread: Re: [HACKERS] notice about costly ri checks (3)

Re: [HACKERS] notice about costly ri checks (3)

From
Fabien COELHO
Date:
Hello Bruce,

> Subject: Re: [HACKERS] notice about costly ri checks (3)
> Your patch has been added to the PostgreSQL unapplied patches list at:
>     http://momjian.postgresql.org/cgi-bin/pgpatches

I hope you put version (4), not version (3) ! Otherwise the new
wording is not the "new new one" discussed later...

--
Fabien Coelho - coelho@cri.ensmp.fr

Re: [HACKERS] notice about costly ri checks (3)

From
Fabien COELHO
Date:
> > Subject: Re: [HACKERS] notice about costly ri checks (3)
>
> I hope you put version (4), not version (3)! Otherwise the new
> wording is not the "new new one" discussed later...

I just checked. You put version 3 in line (NOTICE, no precision about
offending attributes), although a later discussion seemed to decide that a
WARNING was better, and that attributes and types should be shown, hence
version (4).

So, if you can update, it would be better!

Sorry for the inconvenience, have a nice day,

--
Fabien Coelho - coelho@cri.ensmp.fr

Re: [HACKERS] notice about costly ri checks (3)

From
Bruce Momjian
Date:
Thanks.  Done.

---------------------------------------------------------------------------

Fabien COELHO wrote:
>
> > > Subject: Re: [HACKERS] notice about costly ri checks (3)
> >
> > I hope you put version (4), not version (3)! Otherwise the new
> > wording is not the "new new one" discussed later...
>
> I just checked. You put version 3 in line (NOTICE, no precision about
> offending attributes), although a later discussion seemed to decide that a
> WARNING was better, and that attributes and types should be shown, hence
> version (4).
>
> So, if you can update, it would be better!
>
> Sorry for the inconvenience, have a nice day,
>
> --
> Fabien Coelho - coelho@cri.ensmp.fr
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faqs/FAQ.html
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: [HACKERS] notice about costly ri checks (3)

From
Fabien COELHO
Date:
Dear Bruce,

# [PATCHES] notice about costly ri checks (2), Fabien COELHO

This one which appears on the web page can also be removed,
It is also replaced by version 4.

Sorry again for the inconvenience, have a nice day,

--
Fabien Coelho - coelho@cri.ensmp.fr

Re: [HACKERS] notice about costly ri checks (3)

From
Bruce Momjian
Date:
Fabien COELHO wrote:
>
> Dear Bruce,
>
> # [PATCHES] notice about costly ri checks (2), Fabien COELHO
>
> This one which appears on the web page can also be removed,
> It is also replaced by version 4.
>
> Sorry again for the inconvenience, have a nice day,

It is in the queue because I need that narrative for the commit
messase.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: [HACKERS] notice about costly ri checks (3)

From
Fabien COELHO
Date:
Dear Bruce,

> It is in the queue because I need that narrative for the commit
> messase.

Ok, I get the point.

I should have made a fully standalone version with all comments repeated.

Thanks, have a nice day,

--
Fabien Coelho - coelho@cri.ensmp.fr

Re: [HACKERS] notice about costly ri checks (3)

From
Bruce Momjian
Date:
Fabien COELHO wrote:
>
> Dear Bruce,
>
> > It is in the queue because I need that narrative for the commit
> > messase.
>
> Ok, I get the point.
>
> I should have made a fully standalone version with all comments repeated.
>
> Thanks, have a nice day,

No problem. I am used to keeping multiple versions for the comments.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073