Thread: Re: Update tests & memory leak fix
Sorry guys, last diff wasn't a context one! "diff -c" attached this time round... L. ----- Original Message ----- From: Lee Kindness To: pgsql-patches@postgresql.org Cc: Bruce Momjian ; Lee Kindness ; Shridhar Daithankar Sent: Saturday, March 06, 2004 3:07 PM Subject: ECPG: Update tests & memory leak fix See attached diff which corrects a per-thread memory leak in libecpg and changes the thread test program to create a user defined number of threads. Also attached tar.gz adds an additional thread test, which currently does NOT work as expected and is one of the cases Shridar and I will be looking at (removing need for AT xxx on every EXEC SQL). Note, the updated test shows that ECPG currently DOES support the specification of connection names by host variables (not only static strings as I had said previously). Thanks, L.
Attachment
Got the diff -c now, thanks. --------------------------------------------------------------------------- Lee Kindness wrote: > Sorry guys, last diff wasn't a context one! "diff -c" attached this time > round... > > L. > > ----- Original Message ----- > From: Lee Kindness > To: pgsql-patches@postgresql.org > Cc: Bruce Momjian ; Lee Kindness ; Shridhar Daithankar > Sent: Saturday, March 06, 2004 3:07 PM > Subject: ECPG: Update tests & memory leak fix > > See attached diff which corrects a per-thread memory leak in libecpg and > changes the thread test program to create a user defined number of threads. > Also attached tar.gz adds an additional thread test, which currently does > NOT work as expected and is one of the cases Shridar and I will be looking > at (removing need for AT xxx on every EXEC SQL). > > Note, the updated test shows that ECPG currently DOES support the > specification of connection names by host variables (not only static strings > as I had said previously). > > Thanks, L. [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 9: the planner will ignore your desire to choose an index scan if your > joining column's datatypes do not match -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Bruce, do you have an update on when this patch (and the subsequent one) will be applied or rejected? Thanks, Lee. Bruce Momjian writes Mon, 8 Mar 2004: > > Got the diff -c now, thanks. > > --------------------------------------------------------------------------- > > Lee Kindness wrote: > > Sorry guys, last diff wasn't a context one! "diff -c" attached this time > > round... > > > > L. > > > > ----- Original Message ----- > > From: Lee Kindness > > To: pgsql-patches@postgresql.org > > Cc: Bruce Momjian ; Lee Kindness ; Shridhar Daithankar > > Sent: Saturday, March 06, 2004 3:07 PM > > Subject: ECPG: Update tests & memory leak fix > > > > See attached diff which corrects a per-thread memory leak in libecpg and > > changes the thread test program to create a user defined number of threads. > > Also attached tar.gz adds an additional thread test, which currently does > > NOT work as expected and is one of the cases Shridar and I will be looking > > at (removing need for AT xxx on every EXEC SQL). > > > > Note, the updated test shows that ECPG currently DOES support the > > specification of connection names by host variables (not only static strings > > as I had said previously). > > > > Thanks, L. > > [ Attachment, skipping... ] > > > > > ---------------------------(end of broadcast)--------------------------- > > TIP 9: the planner will ignore your desire to choose an index scan if your > > joining column's datatypes do not match > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 359-1001 > + If your life is a hard drive, | 13 Roberts Road > + Christ can be your backup. | Newtown Square, Pennsylvania 19073
I will put it in the queue today. --------------------------------------------------------------------------- Lee Kindness wrote: > Bruce, do you have an update on when this patch (and the subsequent > one) will be applied or rejected? > > Thanks, Lee. > > Bruce Momjian writes Mon, 8 Mar 2004: > > > > Got the diff -c now, thanks. > > > > --------------------------------------------------------------------------- > > > > Lee Kindness wrote: > > > Sorry guys, last diff wasn't a context one! "diff -c" attached this time > > > round... > > > > > > L. > > > > > > ----- Original Message ----- > > > From: Lee Kindness > > > To: pgsql-patches@postgresql.org > > > Cc: Bruce Momjian ; Lee Kindness ; Shridhar Daithankar > > > Sent: Saturday, March 06, 2004 3:07 PM > > > Subject: ECPG: Update tests & memory leak fix > > > > > > See attached diff which corrects a per-thread memory leak in libecpg and > > > changes the thread test program to create a user defined number of threads. > > > Also attached tar.gz adds an additional thread test, which currently does > > > NOT work as expected and is one of the cases Shridar and I will be looking > > > at (removing need for AT xxx on every EXEC SQL). > > > > > > Note, the updated test shows that ECPG currently DOES support the > > > specification of connection names by host variables (not only static strings > > > as I had said previously). > > > > > > Thanks, L. > > > > [ Attachment, skipping... ] > > > > > > > > ---------------------------(end of broadcast)--------------------------- > > > TIP 9: the planner will ignore your desire to choose an index scan if your > > > joining column's datatypes do not match > > > > -- > > Bruce Momjian | http://candle.pha.pa.us > > pgman@candle.pha.pa.us | (610) 359-1001 > > + If your life is a hard drive, | 13 Roberts Road > > + Christ can be your backup. | Newtown Square, Pennsylvania 19073 > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073