Thread: ECPG: Update tests & memory leak fix

ECPG: Update tests & memory leak fix

From
"Lee Kindness"
Date:
See attached diff which corrects a per-thread memory leak in libecpg and changes the thread test program to create a user defined number of threads. Also attached tar.gz adds an additional thread test, which currently does NOT work as expected and is one of the cases Shridar and I will be looking at (removing need for AT xxx on every EXEC SQL).
 
Note, the updated test shows that ECPG currently DOES support the specification of connection names by host variables (not only static strings as I had said previously).
 
Thanks, L.
Attachment

Re: ECPG: Update tests & memory leak fix

From
Bruce Momjian
Date:
I need a context diff, diff -c.

---------------------------------------------------------------------------

Lee Kindness wrote:
> See attached diff which corrects a per-thread memory leak in libecpg and changes the thread test program to create a
userdefined number of threads. Also attached tar.gz adds an additional thread test, which currently does NOT work as
expectedand is one of the cases Shridar and I will be looking at (removing need for AT xxx on every EXEC SQL). 
>
> Note, the updated test shows that ECPG currently DOES support the specification of connection names by host variables
(notonly static strings as I had said previously). 
>
> Thanks, L.

[ Attachment, skipping... ]

[ Attachment, skipping... ]

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: ECPG: Update tests & memory leak fix

From
Bruce Momjian
Date:
[ Using diff -c version.]

Your patch has been added to the PostgreSQL unapplied patches list at:

    http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Lee Kindness wrote:
> See attached diff which corrects a per-thread memory leak in libecpg and changes the thread test program to create a
userdefined number of threads. Also attached tar.gz adds an additional thread test, which currently does NOT work as
expectedand is one of the cases Shridar and I will be looking at (removing need for AT xxx on every EXEC SQL). 
>
> Note, the updated test shows that ECPG currently DOES support the specification of connection names by host variables
(notonly static strings as I had said previously). 
>
> Thanks, L.

[ Attachment, skipping... ]

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faqs/FAQ.html

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: ECPG: Update tests & memory leak fix

From
Bruce Momjian
Date:
Patch applied by Michael.  Thanks.

---------------------------------------------------------------------------


Lee Kindness wrote:
> See attached diff which corrects a per-thread memory leak in libecpg and changes the thread test program to create a
userdefined number of threads. Also attached tar.gz adds an additional thread test, which currently does NOT work as
expectedand is one of the cases Shridar and I will be looking at (removing need for AT xxx on every EXEC SQL). 
>
> Note, the updated test shows that ECPG currently DOES support the specification of connection names by host variables
(notonly static strings as I had said previously). 
>
> Thanks, L.

[ Attachment, skipping... ]

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faqs/FAQ.html

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073