Thread: enable jade warnings

Attached is a crude patch to enable some additional jade/openjade
warnings. This should help us catch improper or ill-advised SGML in
the docs.

I disabled the warning for empty tags, as they are used throughout the
SGML docs and there is no point in getting rid of them. I also
disabled the warning for unused parameter types, as that triggers a
warning in a system DTD on my machine.

Unless anyone objects, I'll apply this within 24 hours.

-Neil
Index: doc/src/sgml/Makefile
===================================================================
RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/Makefile,v
retrieving revision 1.64
diff -c -r1.64 Makefile
*** a/doc/src/sgml/Makefile    15 Jan 2004 23:51:32 -0000    1.64
--- b/doc/src/sgml/Makefile    29 Feb 2004 16:35:07 -0000
***************
*** 58,63 ****
--- 58,65 ----
  override JADEFLAGS += -V draft-mode
  endif

+ # Enable some extra jade warnings
+ override JADEFLAGS += -wall -wno-unused-param -wno-empty

  ##
  ## Man pages
***************
*** 220,226 ****

  # Quick syntax check without style processing
  check: postgres.sgml $(ALLSGML)
!     $(NSGMLS) $(SGMLINCLUDE) -s $<


  ##
--- 222,228 ----

  # Quick syntax check without style processing
  check: postgres.sgml $(ALLSGML)
!     $(NSGMLS) -wall -wno-empty -wno-unused-param $(SGMLINCLUDE) -s $<


  ##

Neil Conway wrote:
> Attached is a crude patch to enable some additional jade/openjade
> warnings. This should help us catch improper or ill-advised SGML in
> the docs.

If that doesn't create any new warnings on the current (fixed) code,
then I agree with this.  However, I'd like to see it factored more to
avoid repeating it for jade and nsgmls.  The warning flags are in fact
SP flags, not Jade flags; only Jade is built on top of SP.  So maybe
assign this to SPFLAGS and add that to both invocations.  (This is a
bit analogous to CPPFLAGS vs. CFLAGS.)

Peter Eisentraut wrote:
> If that doesn't create any new warnings on the current (fixed) code,
> then I agree with this.

(Right, it does not.)

> However, I'd like to see it factored more to
> avoid repeating it for jade and nsgmls.  The warning flags are in fact
> SP flags, not Jade flags; only Jade is built on top of SP.  So maybe
> assign this to SPFLAGS and add that to both invocations.  (This is a
> bit analogous to CPPFLAGS vs. CFLAGS.)

Attached is a patch that does this.

-Neil
Index: doc/src/sgml/Makefile
===================================================================
RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/Makefile,v
retrieving revision 1.64
diff -c -r1.64 Makefile
*** a/doc/src/sgml/Makefile    15 Jan 2004 23:51:32 -0000    1.64
--- b/doc/src/sgml/Makefile    29 Feb 2004 17:11:59 -0000
***************
*** 58,63 ****
--- 58,65 ----
  override JADEFLAGS += -V draft-mode
  endif

+ # Enable some extra warnings
+ override SPFLAGS += -wall -wno-unused-param -wno-empty

  ##
  ## Man pages
***************
*** 86,92 ****

  html: postgres.sgml $(ALLSGML) stylesheet.dsl
      @rm -f *.html
!     $(JADE) $(JADEFLAGS) $(SGMLINCLUDE) $(CATALOG) -d stylesheet.dsl -i output-html -t sgml $<
  ifeq ($(vpath_build), yes)
      @cp $(srcdir)/stylesheet.css .
  endif
--- 88,94 ----

  html: postgres.sgml $(ALLSGML) stylesheet.dsl
      @rm -f *.html
!     $(JADE) $(JADEFLAGS) $(SPFLAGS) $(SGMLINCLUDE) $(CATALOG) -d stylesheet.dsl -i output-html -t sgml $<
  ifeq ($(vpath_build), yes)
      @cp $(srcdir)/stylesheet.css .
  endif
***************
*** 220,226 ****

  # Quick syntax check without style processing
  check: postgres.sgml $(ALLSGML)
!     $(NSGMLS) $(SGMLINCLUDE) -s $<


  ##
--- 222,228 ----

  # Quick syntax check without style processing
  check: postgres.sgml $(ALLSGML)
!     $(NSGMLS) $(SPFLAGS) $(SGMLINCLUDE) -s $<


  ##