Postgres Pro
Downloads
Home   >   mailing lists

Thread: Two very minor win32 patches

Two very minor win32 patches

From
Claudio Natoli
Date:
For src/backend/postmaster/postmaster.c and src/include/c.h
(Note: should ioctlsocket_ret be initialized to 1 for BEOS too, and can it
take an unsigned parameter? If so, could simplify.)





---
WE HAVE MOVED - PLEASE NOTE OUR NEW CONTACT DETAILS:
THE BASEMENT, 33 EWELL STREET, BALMAIN NSW 2041
TEL: +61 2 9555 1544 FAX: +61 2 9555 6911
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
http://www.memetrics.com/emailpolicy.html
Attachment

Re: Two very minor win32 patches

From
Bruce Momjian
Date:
Claudio Natoli wrote:
> For src/backend/postmaster/postmaster.c and src/include/c.h
> (Note: should ioctlsocket_ret be initialized to 1 for BEOS too, and can it
> take an unsigned parameter? If so, could simplify.)

OK, I have updated this for 7.4 and CVS.  Any idea why it has to be
initialized to 1 and not 0?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: Two very minor win32 patches

From
Bruce Momjian
Date:
Bruce Momjian wrote:
> Claudio Natoli wrote:
> > For src/backend/postmaster/postmaster.c and src/include/c.h
> > (Note: should ioctlsocket_ret be initialized to 1 for BEOS too, and can it
> > take an unsigned parameter? If so, could simplify.)
>
> OK, I have updated this for 7.4 and CVS.  Any idea why it has to be
> initialized to 1 and not 0?

Never mind --- I figured it out:

FIONBIO
    The argp parameter is a pointer to an unsigned long value. Set argp
to a nonzero value if the nonblocking mode should be enabled, or zero if
the nonblocking mode should be disabled. When a socket is created, it
operates in blocking mode by default (nonblocking mode is disabled).
This is consistent with BSD sockets.

    argp value     Nonblocking mode

    0     Disabled
    nonzero     Enabled

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/winsock/ioctlsocket_2.asp

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073