Thread: Patch for select() -> poll() in libpq

Patch for select() -> poll() in libpq

From
Anne Dudfield
Date:
Hi, we recently were using the libpq++ interface to postgres in a
program that had many filehandles open. We of course ran into the bug
with select() where filehandles above 1024 cause serious problems.
I fixed the bug by replacing select() with poll() in libpq/fe-misc.c.

I was going to file a bug, but I saw that this problem had already
been fixed in CVS. Unfortunately, it does not appear to be fixed in
the latest postgres version (7.3.4). When will you release a patch
with this fix in it?

Please reply to me, as I am not on the mailing list.

thanks,
Anne Dudfield

Re: Patch for select() -> poll() in libpq

From
Tom Lane
Date:
Anne Dudfield <anne@mazunetworks.com> writes:
> I was going to file a bug, but I saw that this problem had already
> been fixed in CVS. Unfortunately, it does not appear to be fixed in
> the latest postgres version (7.3.4). When will you release a patch
> with this fix in it?

7.4.  We are not going to back-patch this, since it creates portability
hazards that we can't risk without a proper beta test cycle.

Feel free to back-patch locally if it's in your way.

            regards, tom lane