Thread: pgstattuple for schemas
Using a table name requires that the table be in the current search path, which for single use might be fine but not for an interface. Add a pgstattuplebyid(oid) function. Also, qualify DUMMY_TUPLE (reference to Type) since we cannot guarentee that public is in the search path. Assume installation script installs to public, which it already did. -- Rod Taylor <rbt@rbt.ca> PGP Key: http://www.rbt.ca/rbtpub.asc
Attachment
Rod Taylor <rbt@rbt.ca> writes:
> Using a table name requires that the table be in the current search
> path, which for single use might be fine but not for an interface.
Actually, it requires no such thing, because the code is already
schema-aware -- you can do pgstattuple('foo.bar').
> Add a pgstattuplebyid(oid) function.
Perhaps this is worth having, but not for the reason given above.
regards, tom lane
On Fri, 2003-05-23 at 09:15, Tom Lane wrote:
> Rod Taylor <rbt@rbt.ca> writes:
> > Using a table name requires that the table be in the current search
> > path, which for single use might be fine but not for an interface.
>
> Actually, it requires no such thing, because the code is already
> schema-aware -- you can do pgstattuple('foo.bar').
heh.. didn't even think of trying that (obviously).
> > Add a pgstattuplebyid(oid) function.
>
> Perhaps this is worth having, but not for the reason given above.
This is a much easier form to deal with in code. If it can be added for
that reason, it would be appreciated.
--
Rod Taylor <rbt@rbt.ca>
PGP Key: http://www.rbt.ca/rbtpub.asc
Attachment
I have updated the pgstattuple readme with this TODO item. Does anyone have the patch mentioned to implement this? --------------------------------------------------------------------------- Rod Taylor wrote: -- Start of PGP signed section. > On Mon, 2003-06-02 at 16:16, Bruce Momjian wrote: > > Added to pgstattuple README: > > > > TODO: Allow pgstattuple to accept oids. > > There is a patch in that thread for this... > > I'd find it but -archives seems to be having issues at the moment. > -- > Rod Taylor <rbt@rbt.ca> > > PGP Key: http://www.rbt.ca/rbtpub.asc -- End of PGP section, PGP failed! -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
On Wed, 2003-06-04 at 17:47, Bruce Momjian wrote: > I have updated the pgstattuple readme with this TODO item. Does anyone > have the patch mentioned to implement this? Attached > --------------------------------------------------------------------------- > > Rod Taylor wrote: > -- Start of PGP signed section. > > On Mon, 2003-06-02 at 16:16, Bruce Momjian wrote: > > > Added to pgstattuple README: > > > > > > TODO: Allow pgstattuple to accept oids. > > > > There is a patch in that thread for this... > > > > I'd find it but -archives seems to be having issues at the moment. > > -- > > Rod Taylor <rbt@rbt.ca> > > > > PGP Key: http://www.rbt.ca/rbtpub.asc > -- End of PGP section, PGP failed! -- Rod Taylor <rbt@rbt.ca> PGP Key: http://www.rbt.ca/rbtpub.asc
Attachment
Rod Taylor <rbt@rbt.ca> writes:
> CREATE OR REPLACE FUNCTION pgstattuple(text) RETURNS pgstattuple_type
> AS 'MODULE_PATHNAME', 'pgstattuple'
> ! LANGUAGE 'c' STRICT;
> !=20
> ! CREATE OR REPLACE FUNCTION pgstattuple(oid) RETURNS pgstattuple_type
> ! AS 'MODULE_PATHNAME', 'pgstattuple'
> ! LANGUAGE 'c' STRICT;
Surely not.
regards, tom lane
> Surely not. New patch with corrected README attached. Also quickly added mention that it may be a qualified schema name. -- Rod Taylor <rbt@rbt.ca> PGP Key: http://www.rbt.ca/rbtpub.asc
Attachment
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Rod Taylor wrote:
-- Start of PGP signed section.
> > Surely not.
>
> New patch with corrected README attached.
>
> Also quickly added mention that it may be a qualified schema name.
>
> --
> Rod Taylor <rbt@rbt.ca>
>
> PGP Key: http://www.rbt.ca/rbtpub.asc
[ Attachment, skipping... ]
-- End of PGP section, PGP failed!
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Patch applied. Thanks. --------------------------------------------------------------------------- Rod Taylor wrote: -- Start of PGP signed section. > > Surely not. > > New patch with corrected README attached. > > Also quickly added mention that it may be a qualified schema name. > > -- > Rod Taylor <rbt@rbt.ca> > > PGP Key: http://www.rbt.ca/rbtpub.asc [ Attachment, skipping... ] -- End of PGP section, PGP failed! -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073