Thread: Cygwin PostgreSQL CVS Patch
The attached patch enables PostgreSQL CVS to build under Cygwin again.
It corrects the problems reported in the following mailing list thread:
http://archives.postgresql.org/pgsql-cygwin/2003-04/msg00048.php
and a few others.
The following is a summary of the proposed changes:
1. include/port/cygwin.h:
Remove #include to port/win32defs.h which is obsolete.
2. include/utils/elog.h:
Add DLLIMPORT to error_context_stack.
3. interfaces/ecpg/Makefile:
Change build order so pgtypeslib is built before ecpglib and
compatlib which depend on it.
4. interfaces/ecpg/compatlib/Makefile:
Add link with -lpgtypes under Cygwin.
Note: There maybe a better way to affect this change -- I'm quite
open to suggestions.
5. interfaces/ecpg/compatlib/informix.c:
Change strndup() prototype to be consistent with a system supplied
one to prevent compilation errors.
Note: This change should probably be handled via autoconf, but I'm
hoping that maybe Michael Meskes would be willing to do this. :,)
6. interfaces/ecpg/ecpglib/Makefile:
Add link with -lpgtypes under Cygwin.
Note: There maybe a better way to affect this change -- I'm quite
open to suggestions.
7. interfaces/ecpg/include/sqlca.h:
Change DLLIMPORT definition to export functions when building a DLL.
8. makefiles/Makefile.cygwin:
Change an ecpg path to match the current directory structure.
Thanks,
Jason
--
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6
Attachment
On Wed, May 07, 2003 at 04:45:43PM -0400, Jason Tishler wrote: > The attached patch enables PostgreSQL CVS to build under Cygwin again. > It corrects the problems reported in the following mailing list > thread: > > http://archives.postgresql.org/pgsql-cygwin/2003-04/msg00048.php > > and a few others. > > The following is a summary of the proposed changes: > > [snip] Ping? Is there anything I can do to facilitate the acceptance of this patch? Thanks, Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6
Still slogging through, hopefully this week. --------------------------------------------------------------------------- Jason Tishler wrote: > On Wed, May 07, 2003 at 04:45:43PM -0400, Jason Tishler wrote: > > The attached patch enables PostgreSQL CVS to build under Cygwin again. > > It corrects the problems reported in the following mailing list > > thread: > > > > http://archives.postgresql.org/pgsql-cygwin/2003-04/msg00048.php > > > > and a few others. > > > > The following is a summary of the proposed changes: > > > > [snip] > > Ping? > > Is there anything I can do to facilitate the acceptance of this patch? > > Thanks, > Jason > > -- > PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers > Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6 > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Jason Tishler wrote:
> The attached patch enables PostgreSQL CVS to build under Cygwin again.
> It corrects the problems reported in the following mailing list thread:
>
> http://archives.postgresql.org/pgsql-cygwin/2003-04/msg00048.php
>
> and a few others.
>
> The following is a summary of the proposed changes:
>
> 1. include/port/cygwin.h:
>
> Remove #include to port/win32defs.h which is obsolete.
>
> 2. include/utils/elog.h:
>
> Add DLLIMPORT to error_context_stack.
>
> 3. interfaces/ecpg/Makefile:
>
> Change build order so pgtypeslib is built before ecpglib and
> compatlib which depend on it.
>
> 4. interfaces/ecpg/compatlib/Makefile:
>
> Add link with -lpgtypes under Cygwin.
>
> Note: There maybe a better way to affect this change -- I'm quite
> open to suggestions.
>
> 5. interfaces/ecpg/compatlib/informix.c:
>
> Change strndup() prototype to be consistent with a system supplied
> one to prevent compilation errors.
>
> Note: This change should probably be handled via autoconf, but I'm
> hoping that maybe Michael Meskes would be willing to do this. :,)
>
> 6. interfaces/ecpg/ecpglib/Makefile:
>
> Add link with -lpgtypes under Cygwin.
>
> Note: There maybe a better way to affect this change -- I'm quite
> open to suggestions.
>
> 7. interfaces/ecpg/include/sqlca.h:
>
> Change DLLIMPORT definition to export functions when building a DLL.
>
> 8. makefiles/Makefile.cygwin:
>
> Change an ecpg path to match the current directory structure.
>
> Thanks,
> Jason
>
> --
> PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
> Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
It appears this was applied by Peter. --------------------------------------------------------------------------- Jason Tishler wrote: > The attached patch enables PostgreSQL CVS to build under Cygwin again. > It corrects the problems reported in the following mailing list thread: > > http://archives.postgresql.org/pgsql-cygwin/2003-04/msg00048.php > > and a few others. > > The following is a summary of the proposed changes: > > 1. include/port/cygwin.h: > > Remove #include to port/win32defs.h which is obsolete. > > 2. include/utils/elog.h: > > Add DLLIMPORT to error_context_stack. > > 3. interfaces/ecpg/Makefile: > > Change build order so pgtypeslib is built before ecpglib and > compatlib which depend on it. > > 4. interfaces/ecpg/compatlib/Makefile: > > Add link with -lpgtypes under Cygwin. > > Note: There maybe a better way to affect this change -- I'm quite > open to suggestions. > > 5. interfaces/ecpg/compatlib/informix.c: > > Change strndup() prototype to be consistent with a system supplied > one to prevent compilation errors. > > Note: This change should probably be handled via autoconf, but I'm > hoping that maybe Michael Meskes would be willing to do this. :,) > > 6. interfaces/ecpg/ecpglib/Makefile: > > Add link with -lpgtypes under Cygwin. > > Note: There maybe a better way to affect this change -- I'm quite > open to suggestions. > > 7. interfaces/ecpg/include/sqlca.h: > > Change DLLIMPORT definition to export functions when building a DLL. > > 8. makefiles/Makefile.cygwin: > > Change an ecpg path to match the current directory structure. > > Thanks, > Jason > > -- > PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers > Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6 [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Bruce, On Mon, Jun 02, 2003 at 03:08:20PM -0400, Bruce Momjian wrote: > It appears this was applied by Peter. Now that anonymous CVS is back up, I am able to verify that the patch was applied (with some tweaking) and CVS HEAD builds cleanly under Cygwin again. Thanks, Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6