Thread: Object (Domain) locking
Sorry, sending this wile packing to leave for a week... It should be ok. - Modifies LOCKTAG to include a 'classId'. Relation receive a classId of RelOid_pg_class, and transaction locks XactLockTableId. RelId is renamed to objId. - LockObject() and UnlockObject() functions created, and their use sprinkled throughout the code to do descent locking for domains and types. They accept lock modes AccessShare and AccessExclusive, as we only really need a 'read' and 'write' lock at the moment. Most locking cases are held until the end of the transaction. This fixes the cases Tom mentioned earlier in regards to locking with Domains. If the patch is good, I'll work on cleaning up issues with other database objects that have this problem (most of them). -- Rod Taylor <rbt@rbt.ca> PGP Key: http://www.rbt.ca/rbtpub.asc
Attachment
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Rod Taylor wrote:
-- Start of PGP signed section.
> Sorry, sending this wile packing to leave for a week... It should be ok.
>
> - Modifies LOCKTAG to include a 'classId'. Relation receive a classId of
> RelOid_pg_class, and transaction locks XactLockTableId. RelId is renamed
> to objId.
>
> - LockObject() and UnlockObject() functions created, and their use
> sprinkled throughout the code to do descent locking for domains and
> types. They accept lock modes AccessShare and AccessExclusive, as we
> only really need a 'read' and 'write' lock at the moment. Most locking
> cases are held until the end of the transaction.
>
> This fixes the cases Tom mentioned earlier in regards to locking with
> Domains. If the patch is good, I'll work on cleaning up issues with
> other database objects that have this problem (most of them).
>
> --
> Rod Taylor <rbt@rbt.ca>
>
> PGP Key: http://www.rbt.ca/rbtpub.asc
[ Attachment, skipping... ]
-- End of PGP section, PGP failed!
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Patch applied. Thanks. --------------------------------------------------------------------------- Rod Taylor wrote: -- Start of PGP signed section. > Sorry, sending this wile packing to leave for a week... It should be ok. > > - Modifies LOCKTAG to include a 'classId'. Relation receive a classId of > RelOid_pg_class, and transaction locks XactLockTableId. RelId is renamed > to objId. > > - LockObject() and UnlockObject() functions created, and their use > sprinkled throughout the code to do descent locking for domains and > types. They accept lock modes AccessShare and AccessExclusive, as we > only really need a 'read' and 'write' lock at the moment. Most locking > cases are held until the end of the transaction. > > This fixes the cases Tom mentioned earlier in regards to locking with > Domains. If the patch is good, I'll work on cleaning up issues with > other database objects that have this problem (most of them). > > -- > Rod Taylor <rbt@rbt.ca> > > PGP Key: http://www.rbt.ca/rbtpub.asc [ Attachment, skipping... ] -- End of PGP section, PGP failed! -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
I have backed out this patch because it needs a litte more review. I will be sure it gets in shortly. Sorry, and thanks. --------------------------------------------------------------------------- pgman wrote: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > I will try to apply it within the next 48 hours. > > --------------------------------------------------------------------------- > > > Rod Taylor wrote: > -- Start of PGP signed section. > > Sorry, sending this wile packing to leave for a week... It should be ok. > > > > - Modifies LOCKTAG to include a 'classId'. Relation receive a classId of > > RelOid_pg_class, and transaction locks XactLockTableId. RelId is renamed > > to objId. > > > > - LockObject() and UnlockObject() functions created, and their use > > sprinkled throughout the code to do descent locking for domains and > > types. They accept lock modes AccessShare and AccessExclusive, as we > > only really need a 'read' and 'write' lock at the moment. Most locking > > cases are held until the end of the transaction. > > > > This fixes the cases Tom mentioned earlier in regards to locking with > > Domains. If the patch is good, I'll work on cleaning up issues with > > other database objects that have this problem (most of them). > > > > -- > > Rod Taylor <rbt@rbt.ca> > > > > PGP Key: http://www.rbt.ca/rbtpub.asc > > [ Attachment, skipping... ] > -- End of PGP section, PGP failed! > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 359-1001 > + If your life is a hard drive, | 13 Roberts Road > + Christ can be your backup. | Newtown Square, Pennsylvania 19073 -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
On Wed, 2003-02-19 at 18:47, Bruce Momjian wrote: > I have backed out this patch because it needs a litte more review. I > will be sure it gets in shortly. Sorry, and thanks. Take your time. -- Rod Taylor <rbt@rbt.ca> PGP Key: http://www.rbt.ca/rbtpub.asc