Thread: Re: [HACKERS]

Re: [HACKERS]

From
"Christopher Kings-Lynne"
Date:
You're right.  It's a type in pg_dumpall.c

I have attached a fix for it.

Chris

> > ;CREATE DATABASE keystone WITH OWNER = chriskl TEMPLATE =
> template0 ENCODING
> > = 'SQL_ASCII';
> >
> > Why are all the CREATE DATABASE statements commented out?
> Surely that will
> > make the restore fail?
>
> Just guessing:
>
> The first line does not have a ; at the end; so the first semicolon (at
> the beginning of second line) will end the first line; will not comment
> the CREATE DATABASE line...
>
> I mean, it might work as below:
> DROP DATABASE au_shipping;
>
> CREATE DATABASE au_shipping WITH OWNER = auadmin TEMPLATE = template0
> ENCODING = 'SQL_ASCII';


Attachment

Re: [HACKERS]

From
Tom Lane
Date:
"Christopher Kings-Lynne" <chriskl@familyhealth.com.au> writes:
> You're right.  It's a type in pg_dumpall.c

A harmless typo --- the lines aren't "commented out" (I think your
assembly-language background is showing ;-)).  But it is pretty ugly
output all the same.  Have applied the patch.

            regards, tom lane