Thread: disabled, deferred triggers
This trivial patch implements disabled, deferred triggers, per my proposal on -hackers a couple days ago. The 'tgenabled' status of the trigger is consulted when the trigger is added to the deferred queue (i.e. when the event occurs that fires the trigger), not when the deferred event is executed. No regression tests, as another bug prevents them (the pg_trigger row for a trigger is only loaded once per session, so any changes to it are not noticed unless the client disconnects and reconnects). Cheers, Neil -- Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC
Attachment
On Thu, 2002-12-19 at 14:03, Neil Conway wrote: > This trivial patch implements disabled, deferred triggers, per my > proposal on -hackers a couple days ago. Uh, yeah -- apparently, not *that* trivial :-) This reversion fixes a stupid oversight in the previous patch. Cheers, Neil -- Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC
Attachment
On Thu, 2002-12-19 at 14:43, Neil Conway wrote: > On Thu, 2002-12-19 at 14:03, Neil Conway wrote: > > This trivial patch implements disabled, deferred triggers, per my > > proposal on -hackers a couple days ago. This patch has not been applied. If there's a specific improvement you'd like me to make before it can be accepted, please let me know. Cheers, Neil -- Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC
My fault. I am running behind because of some IPv6 patch work, and the holidays. I will look at them tomorrow. --------------------------------------------------------------------------- Neil Conway wrote: > On Thu, 2002-12-19 at 14:43, Neil Conway wrote: > > On Thu, 2002-12-19 at 14:03, Neil Conway wrote: > > > This trivial patch implements disabled, deferred triggers, per my > > > proposal on -hackers a couple days ago. > > This patch has not been applied. If there's a specific improvement you'd > like me to make before it can be accepted, please let me know. > > Cheers, > > Neil > -- > Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC > > > > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Neil Conway wrote:
> On Thu, 2002-12-19 at 14:03, Neil Conway wrote:
> > This trivial patch implements disabled, deferred triggers, per my
> > proposal on -hackers a couple days ago.
>
> Uh, yeah -- apparently, not *that* trivial :-)
>
> This reversion fixes a stupid oversight in the previous patch.
>
> Cheers,
>
> Neil
> --
> Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC
>
>
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Patch applied. Thanks. --------------------------------------------------------------------------- Neil Conway wrote: > This trivial patch implements disabled, deferred triggers, per my > proposal on -hackers a couple days ago. The 'tgenabled' status of the > trigger is consulted when the trigger is added to the deferred queue > (i.e. when the event occurs that fires the trigger), not when the > deferred event is executed. > > No regression tests, as another bug prevents them (the pg_trigger row > for a trigger is only loaded once per session, so any changes to it are > not noticed unless the client disconnects and reconnects). > > Cheers, > > Neil > -- > Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC > > [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
I actually applied this one. --------------------------------------------------------------------------- Neil Conway wrote: > On Thu, 2002-12-19 at 14:03, Neil Conway wrote: > > This trivial patch implements disabled, deferred triggers, per my > > proposal on -hackers a couple days ago. > > Uh, yeah -- apparently, not *that* trivial :-) > > This reversion fixes a stupid oversight in the previous patch. > > Cheers, > > Neil > -- > Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC > > [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073