Thread: float8 functions
This patch adds some missing functions for float8 math operations, specifically ceil(), floor(), and sign(). There may be other functions that need to be added, but this is a start. I've included some simple regression tests. Unless anyone sees a problem, please add this to the 7.4 queue. Cheers, Neil -- Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC
Attachment
This has been saved for the 7.4 release: http://candle.pha.pa.us/cgi-bin/pgpatches2 --------------------------------------------------------------------------- Neil Conway wrote: > This patch adds some missing functions for float8 math operations, > specifically ceil(), floor(), and sign(). There may be other functions > that need to be added, but this is a start. I've included some simple > regression tests. > > Unless anyone sees a problem, please add this to the 7.4 queue. > > Cheers, > > Neil > > -- > Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Neil Conway <neilc@samurai.com> writes: > Unless anyone sees a problem, please add this to the 7.4 queue. Since it appears that we're requiring an initdb for beta3 anyway, would this be appropriate for 7.3 instead? IMHO, yes -- feature regressions are not desirable, particularly ones that could bite people while upgrading. And the fix is not very complex... Cheers, Neil -- Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC
Neil Conway wrote: > Neil Conway <neilc@samurai.com> writes: > > Unless anyone sees a problem, please add this to the 7.4 queue. > > Since it appears that we're requiring an initdb for beta3 anyway, > would this be appropriate for 7.3 instead? > > IMHO, yes -- feature regressions are not desirable, particularly ones > that could bite people while upgrading. And the fix is not very > complex... Yes, it is a fix so I will move it to the main patches queue. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Your patch has been added to the PostgreSQL unapplied patches list at: http://candle.pha.pa.us/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --------------------------------------------------------------------------- Neil Conway wrote: > This patch adds some missing functions for float8 math operations, > specifically ceil(), floor(), and sign(). There may be other functions > that need to be added, but this is a start. I've included some simple > regression tests. > > Unless anyone sees a problem, please add this to the 7.4 queue. > > Cheers, > > Neil > > -- > Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Patch applied. Thanks. --------------------------------------------------------------------------- Neil Conway wrote: > This patch adds some missing functions for float8 math operations, > specifically ceil(), floor(), and sign(). There may be other functions > that need to be added, but this is a start. I've included some simple > regression tests. > > Unless anyone sees a problem, please add this to the 7.4 queue. > > Cheers, > > Neil > > -- > Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073