Thread: to_char() code cleanup

to_char() code cleanup

From
Neil Conway
Date:
This patch cleans up some of the code in src/util/adt/formatting.c,
fixes a few minor bugs (typos, potential buffer overruns, etc.), and
fixes some spelling/grammar mistakes.

I did *not* make the to_char() behavior change discussed on -hackers
(although I had originally intended to) -- if anyone else would like
to make those changes, feel free.

Cheers,

Neil

--
Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC

Attachment

Re: to_char() code cleanup

From
Karel Zak
Date:
On Wed, Sep 18, 2002 at 07:19:55PM -0400, Neil Conway wrote:
> I did *not* make the to_char() behavior change discussed on -hackers
> (although I had originally intended to) -- if anyone else would like
> to make those changes, feel free.

 I'm fixing it right now. The patch will send today.

    Karel

--
 Karel Zak  <zakkr@zf.jcu.cz>
 http://home.zf.jcu.cz/~zakkr/

 C, PostgreSQL, PHP, WWW, http://docs.linux.cz, http://mape.jcu.cz

Re: to_char() code cleanup

From
Bruce Momjian
Date:
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Neil Conway wrote:
> This patch cleans up some of the code in src/util/adt/formatting.c,
> fixes a few minor bugs (typos, potential buffer overruns, etc.), and
> fixes some spelling/grammar mistakes.
>
> I did *not* make the to_char() behavior change discussed on -hackers
> (although I had originally intended to) -- if anyone else would like
> to make those changes, feel free.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: to_char() code cleanup

From
Bruce Momjian
Date:
Patch applied.  Thanks.

---------------------------------------------------------------------------


Neil Conway wrote:
> This patch cleans up some of the code in src/util/adt/formatting.c,
> fixes a few minor bugs (typos, potential buffer overruns, etc.), and
> fixes some spelling/grammar mistakes.
>
> I did *not* make the to_char() behavior change discussed on -hackers
> (although I had originally intended to) -- if anyone else would like
> to make those changes, feel free.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073