Thread: Superuser Reserved Backend Slots - TODO item
This patch reserves the last superuser_reserved_connections slots for connections by the superuser only. This patch replaces the last patch I sent a couple of days ago. It closes a connection that has not been authorised by a superuser if it would leave less than the GUC variable ReservedBackends (superuser_reserved_connections in postgres.conf) backend process slots free in the SISeg. This differs to the first patch which only reserved the last ReservedBackends slots in the procState array. This has made the free slot test more expensive due to the use of a lock. After thinking about a comment on the first patch I've also made it a fatal error if the number of reserved slots is not less than the maximum number of connections. Passes 'make check' and behaves as expected in my manual tests. -- Nigel J. Andrews Director --- Logictree Systems Limited Computer Consultants
Attachment
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Nigel J. Andrews wrote:
>
>
> This patch reserves the last superuser_reserved_connections slots for
> connections by the superuser only.
>
> This patch replaces the last patch I sent a couple of days ago.
>
> It closes a connection that has not been authorised by a superuser if it would
> leave less than the GUC variable ReservedBackends
> (superuser_reserved_connections in postgres.conf) backend process slots free
> in the SISeg. This differs to the first patch which only reserved the last
> ReservedBackends slots in the procState array. This has made the free slot
> test more expensive due to the use of a lock.
>
> After thinking about a comment on the first patch I've also made it a fatal
> error if the number of reserved slots is not less than the maximum number of
> connections.
>
> Passes 'make check' and behaves as expected in my manual tests.
>
>
> --
> Nigel J. Andrews
> Director
>
> ---
> Logictree Systems Limited
> Computer Consultants
Content-Description:
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Patch applied. Thanks. --------------------------------------------------------------------------- Nigel J. Andrews wrote: > > > This patch reserves the last superuser_reserved_connections slots for > connections by the superuser only. > > This patch replaces the last patch I sent a couple of days ago. > > It closes a connection that has not been authorised by a superuser if it would > leave less than the GUC variable ReservedBackends > (superuser_reserved_connections in postgres.conf) backend process slots free > in the SISeg. This differs to the first patch which only reserved the last > ReservedBackends slots in the procState array. This has made the free slot > test more expensive due to the use of a lock. > > After thinking about a comment on the first patch I've also made it a fatal > error if the number of reserved slots is not less than the maximum number of > connections. > > Passes 'make check' and behaves as expected in my manual tests. > > > -- > Nigel J. Andrews > Director > > --- > Logictree Systems Limited > Computer Consultants Content-Description: [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073