Thread: Minor TOAST patch (regression test and source comment)
Hi all, The following small patch provides a couple of minor updates (against CVS HEAD): Amended "strings" regression test. TOAST tests now insert two values with storage set to "external", to exercise properly the TOAST slice routines which fetch only a subset of the chunks. Changed now-misleading comment on AlterTableCreateToastTable in tablecmds.c, because both columns of the index on a toast table are now used. Regards John -- John Gray Azuli IT www.azuli.co.uk
Attachment
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
John Gray wrote:
> Hi all,
>
> The following small patch provides a couple of minor updates (against
> CVS HEAD):
>
> Amended "strings" regression test. TOAST tests now insert two values
> with storage set to "external", to exercise properly the TOAST slice
> routines which fetch only a subset of the chunks.
>
> Changed now-misleading comment on AlterTableCreateToastTable in
> tablecmds.c, because both columns of the index on a toast table are now
> used.
>
> Regards
>
> John
> --
> John Gray
> Azuli IT
> www.azuli.co.uk
>
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Patch applied. Thanks. --------------------------------------------------------------------------- John Gray wrote: > Hi all, > > The following small patch provides a couple of minor updates (against > CVS HEAD): > > Amended "strings" regression test. TOAST tests now insert two values > with storage set to "external", to exercise properly the TOAST slice > routines which fetch only a subset of the chunks. > > Changed now-misleading comment on AlterTableCreateToastTable in > tablecmds.c, because both columns of the index on a toast table are now > used. > > Regards > > John > -- > John Gray > Azuli IT > www.azuli.co.uk > [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 5: Have you checked our extensive FAQ? > > http://www.postgresql.org/users-lounge/docs/faq.html -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073