Thread: small s_lock.c bug

small s_lock.c bug

From
Joe Conway
Date:
This morning I noticed the following warning:

gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations
-I../../../../src/include   -c -o s_lock.o s_lock.c -MMD
s_lock.c:172:82: warning: multi-line string literals are deprecated

It seems to have been introduced here:
http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/s_lock.c.diff?r1=1.5&r2=1.6

Attached is a small patch.

Joe
Index: src/backend/storage/lmgr//s_lock.c
===================================================================
RCS file: /opt/src/cvs/pgsql/src/backend/storage/lmgr/s_lock.c,v
retrieving revision 1.6
diff -c -r1.6 s_lock.c
*** src/backend/storage/lmgr//s_lock.c    5 Apr 2002 11:38:13 -0000    1.6
--- src/backend/storage/lmgr//s_lock.c    2 May 2002 17:04:04 -0000
***************
*** 174,180 ****
  tas:                            \n\
              .frame    $sp, 0, $31    \n\
              .set push        \n\
!             .set mips2        \n\n
              ll        $14, 0($4)    \n\
              or        $15, $14, 1    \n\
              sc        $15, 0($4)    \n\
--- 174,180 ----
  tas:                            \n\
              .frame    $sp, 0, $31    \n\
              .set push        \n\
!             .set mips2        \n\
              ll        $14, 0($4)    \n\
              or        $15, $14, 1    \n\
              sc        $15, 0($4)    \n\

Re: small s_lock.c bug

From
Tom Lane
Date:
Joe Conway <mail@joeconway.com> writes:
> This morning I noticed the following warning:
> gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations
> -I../../../../src/include   -c -o s_lock.o s_lock.c -MMD
> s_lock.c:172:82: warning: multi-line string literals are deprecated

> Attached is a small patch.

Applied.  Thanks.

            regards, tom lane