Thread: Cygwin plperl patch

Cygwin plperl patch

From
Jason Tishler
Date:
The attached patch enables plperl to build under Cygwin.  It is basically
yet another BE_DLLLIBS patch with a perl MakeMaker twist.  I tried the
patch under Red Hat 7.1 Linux too and I did not observe any ill effects.

Jason

Attachment

Re: Cygwin plperl patch

From
Jason Tishler
Date:
On Fri, Feb 08, 2002 at 08:11:29AM -0500, Jason Tishler wrote:
> The attached patch enables plperl to build under Cygwin.  It is basically
> yet another BE_DLLLIBS patch with a perl MakeMaker twist.  I tried the
> patch under Red Hat 7.1 Linux too and I did not observe any ill effects.

Any status on the above?

Thanks,
Jason

Re: Cygwin plperl patch

From
Tom Lane
Date:
Jason Tishler <jason@tishler.net> writes:
> On Fri, Feb 08, 2002 at 08:11:29AM -0500, Jason Tishler wrote:
>> The attached patch enables plperl to build under Cygwin.  It is basically
>> yet another BE_DLLLIBS patch with a perl MakeMaker twist.  I tried the
>> patch under Red Hat 7.1 Linux too and I did not observe any ill effects.

> Any status on the above?

It's in the queue of stuff waiting to be reviewed and applied after we
make the 7.2/7.3 CVS branch.  Or so I would imagine.  Bruce's page for
pending patches doesn't seem to be showing anything, even though it had
a long list last time I looked...

            regards, tom lane

Re: Cygwin plperl patch

From
Jason Tishler
Date:
Tom,

On Fri, Feb 15, 2002 at 10:27:21AM -0500, Tom Lane wrote:
> Jason Tishler <jason@tishler.net> writes:
> > On Fri, Feb 08, 2002 at 08:11:29AM -0500, Jason Tishler wrote:
> >> The attached patch enables plperl to build under Cygwin.  It is basically
> >> yet another BE_DLLLIBS patch with a perl MakeMaker twist.  I tried the
> >> patch under Red Hat 7.1 Linux too and I did not observe any ill effects.
>
> > Any status on the above?
>
> It's in the queue of stuff waiting to be reviewed and applied after we
> make the 7.2/7.3 CVS branch.  Or so I would imagine.

Thanks for the status update -- it is appreciated.

> Bruce's page for
> pending patches doesn't seem to be showing anything, even though it had
> a long list last time I looked...

The above is the reason for my ping.  As long as it is queued (and not
dropped), then I will be patient.

Thanks,
Jason

Re: Cygwin plperl patch

From
Bruce Momjian
Date:
Sorry I just got to this.  Time for another spin through my email box.
:-)

This has been saved for the 7.3 release:

    http://candle.pha.pa.us/cgi-bin/pgpatches2

---------------------------------------------------------------------------

Jason Tishler wrote:
> The attached patch enables plperl to build under Cygwin.  It is basically
> yet another BE_DLLLIBS patch with a perl MakeMaker twist.  I tried the
> patch under Red Hat 7.1 Linux too and I did not observe any ill effects.
>
> Jason

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Cygwin plperl patch

From
Bruce Momjian
Date:
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Jason Tishler wrote:
> The attached patch enables plperl to build under Cygwin.  It is basically
> yet another BE_DLLLIBS patch with a perl MakeMaker twist.  I tried the
> patch under Red Hat 7.1 Linux too and I did not observe any ill effects.
>
> Jason

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Cygwin plperl patch

From
Bruce Momjian
Date:
Ok'ed by Peter.

Patch applied.  Thanks.

---------------------------------------------------------------------------



Jason Tishler wrote:
> The attached patch enables plperl to build under Cygwin.  It is basically
> yet another BE_DLLLIBS patch with a perl MakeMaker twist.  I tried the
> patch under Red Hat 7.1 Linux too and I did not observe any ill effects.
>
> Jason

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Cygwin plperl patch

From
Bruce Momjian
Date:
Sorry, patch attached.  Applied.

---------------------------------------------------------------------------

Jason Tishler wrote:
> The attached patch enables plperl to build under Cygwin.  It is basically
> yet another BE_DLLLIBS patch with a perl MakeMaker twist.  I tried the
> patch under Red Hat 7.1 Linux too and I did not observe any ill effects.
>
> Jason

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
Index: GNUmakefile
===================================================================
RCS file: /projects/cvsroot/pgsql/src/pl/plperl/GNUmakefile,v
retrieving revision 1.8
diff -c -r1.8 GNUmakefile
*** GNUmakefile    2001/09/16 16:11:11    1.8
--- GNUmakefile    2002/02/08 12:59:29
***************
*** 14,20 ****

  Makefile: Makefile.PL
      plperl_installdir='$$(DESTDIR)$(pkglibdir)' \
!     $(PERL) $< $(makefile_pl_flags) INC='-I$(srcdir) $(filter -I%, $(CPPFLAGS))'

  install: all installdirs
      $(MAKE) -f Makefile install DESTDIR='$(DESTDIR)'
--- 14,21 ----

  Makefile: Makefile.PL
      plperl_installdir='$$(DESTDIR)$(pkglibdir)' \
!     $(PERL) $< $(makefile_pl_flags) LIBS='$(BE_DLLLIBS)' \
!     INC='-I$(srcdir) $(filter -I%, $(CPPFLAGS))'

  install: all installdirs
      $(MAKE) -f Makefile install DESTDIR='$(DESTDIR)'