Thread: [PATCH] GiST code cleanup
Hi all, I was digging through the GiST code, and figured I'd fix up some of the "bad smell" in that code. Stuff like function parameters that aren't used, typos in the comments, comparison between signed and unsigned ints, etc. Attached is a pretty trivial patch; it compiles, but beyond that completely untested. Unless anyone sees any problems, please apply for 7.3. Comments would be appreciated: is this kind of janitorial work welcome? Cheers, Neil -- Neil Conway <neilconway@rogers.com> PGP Key ID: DB3C29FC
Attachment
Oleg gives his OK.
This has been saved for the 7.3 release:
http://candle.pha.pa.us/cgi-bin/pgpatches2
---------------------------------------------------------------------------
Neil Conway wrote:
> Hi all,
>
> I was digging through the GiST code, and figured I'd fix up some of the
> "bad smell" in that code. Stuff like function parameters that aren't
> used, typos in the comments, comparison between signed and unsigned
> ints, etc.
>
> Attached is a pretty trivial patch; it compiles, but beyond that
> completely untested. Unless anyone sees any problems, please apply for
> 7.3.
>
> Comments would be appreciated: is this kind of janitorial work welcome?
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway@rogers.com>
> PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Neil Conway wrote:
> Hi all,
>
> I was digging through the GiST code, and figured I'd fix up some of the
> "bad smell" in that code. Stuff like function parameters that aren't
> used, typos in the comments, comparison between signed and unsigned
> ints, etc.
>
> Attached is a pretty trivial patch; it compiles, but beyond that
> completely untested. Unless anyone sees any problems, please apply for
> 7.3.
>
> Comments would be appreciated: is this kind of janitorial work welcome?
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway@rogers.com>
> PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Patch applied. I checked the other interfaces and this fits with their interfaces. I modified rtree to match the new gist adjuststack() call. --------------------------------------------------------------------------- Neil Conway wrote: > Hi all, > > I was digging through the GiST code, and figured I'd fix up some of the > "bad smell" in that code. Stuff like function parameters that aren't > used, typos in the comments, comparison between signed and unsigned > ints, etc. > > Attached is a pretty trivial patch; it compiles, but beyond that > completely untested. Unless anyone sees any problems, please apply for > 7.3. > > Comments would be appreciated: is this kind of janitorial work welcome? > > Cheers, > > Neil > > -- > Neil Conway <neilconway@rogers.com> > PGP Key ID: DB3C29FC [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026