Thread: Re: pg_hba.conf caching

Re: pg_hba.conf caching

From
Tom Lane
Date:
It seems that the vast bulk of this patch is trivial reformatting of
the existing pg_hba code.  I'm having difficulty seeing what the actual
code changes were --- any chance that you could extract and post just
those diffs?

            regards, tom lane

Re: Re: pg_hba.conf caching

From
Bruce Momjian
Date:
> It seems that the vast bulk of this patch is trivial reformatting of
> the existing pg_hba code.  I'm having difficulty seeing what the actual
> code changes were --- any chance that you could extract and post just
> those diffs?

Yes, I agree it looks that way.  Every access to 'buf' became an access
to 'token'.  I did move the comments to the top of each function rather
than being after the function header.  Not sure how to better present
it.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: pg_hba.conf caching

From
Bruce Momjian
Date:
> It seems that the vast bulk of this patch is trivial reformatting of
> the existing pg_hba code.  I'm having difficulty seeing what the actual
> code changes were --- any chance that you could extract and post just
> those diffs?

Also, as you can see, the actual patch has not appeared on the patches
list yet after two days.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026