Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: GIST question

Re: GIST question

From
Oleg Bartunov
Date:
Bruce,

we dont' see any problem with removing this field (haskeytype)
but it would be **very desirable** first to run regression test
(make installcheck) in contrib/intarray after patch applying.

    Regards,

        Oleg
On Tue, 15 May 2001, Bruce Momjian wrote:

> This GIST question appeared on hackers today.
>
>

    Regards,
        Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83

Re: Re: GIST question

From
Bruce Momjian
Date:
> Bruce,
>
> we dont' see any problem with removing this field (haskeytype)
> but it would be **very desirable** first to run regression test
> (make installcheck) in contrib/intarray after patch applying.

I did.  Regression tests run fine without it.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Re: GIST question

From
Tom Lane
Date:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
>> we dont' see any problem with removing this field (haskeytype)
>> but it would be **very desirable** first to run regression test
>> (make installcheck) in contrib/intarray after patch applying.

> I did.  Regression tests run fine without it.

He asked if you ran the contrib/intarray regress tests, not the
regular ones.  (The other GIST contrib modules would also need
to be tested.)

            regards, tom lane