Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: tiny patch

Re: tiny patch

From
Bruce Momjian
Date:
Thanks.  Applied.

> Bruce,
>
> Noticed a small bug in the code. Probably been there for some time. Note
> that the original code would consider things like UNIX domain sockets are
> regular files.
>
> Gavin Sherry
> Alcove Systems Engineering

Content-Description:

[ Attachment, skipping... ]

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
*** ./backend/utils/init/findbe.c.orig    Thu Mar  8 18:10:54 2001
--- ./backend/utils/init/findbe.c    Thu Mar  8 18:15:04 2001
***************
*** 74,80 ****
                      path);
          return -1;
      }
!     if (!(buf.st_mode & S_IFREG))
      {
          if (DebugLvl > 1)
              fprintf(stderr, "ValidateBinary: \"%s\" is not a regular file\n",
--- 74,82 ----
                      path);
          return -1;
      }
!
!
!     if ((buf.st_mode & S_IFMT) != S_IFREG)
      {
          if (DebugLvl > 1)
              fprintf(stderr, "ValidateBinary: \"%s\" is not a regular file\n",

Re: Re: tiny patch

From
Justin Clift
Date:
Would this have anything to do with why Solaris *sometimes* has problems with
Unix Domain sockets?

???

Regards and best wishes,

Justin Clift

On Thursday 10 May 2001 05:28, Bruce Momjian wrote:
> Thanks.  Applied.
>
> > Bruce,
> >
> > Noticed a small bug in the code. Probably been there for some time. Note
> > that the original code would consider things like UNIX domain sockets are
> > regular files.
> >
> > Gavin Sherry
> > Alcove Systems Engineering
>
> Content-Description:
>
> [ Attachment, skipping... ]

----------------------------------------
Content-Type: text/plain; charset="us-ascii"; name="Attachment: 1"
Content-Transfer-Encoding: 7bit
Content-Description:
----------------------------------------
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://www.postgresql.org/search.mpl

Re: Re: tiny patch

From
Gavin Sherry
Date:
Justin,

No, this problem would occur consistently. The patch cleans up a few lines
of code unrelated to that of opening the UNIX Domain socket for local
database connection.

But, more to the point, what is the problem PG has on solaris with domain
sockets (when it is a problem).

Gavin


On Thu, 10 May 2001, Justin Clift wrote:

> Would this have anything to do with why Solaris *sometimes* has problems with
> Unix Domain sockets?
>
> ???
>
> Regards and best wishes,
>
> Justin Clift
>
> On Thursday 10 May 2001 05:28, Bruce Momjian wrote:
> > Thanks.  Applied.
> >
> > > Bruce,
> > >
> > > Noticed a small bug in the code. Probably been there for some time. Note
> > > that the original code would consider things like UNIX domain sockets are
> > > regular files.
> > >
> > > Gavin Sherry
> > > Alcove Systems Engineering
> >
> > Content-Description:
> >
> > [ Attachment, skipping... ]
>
> ----------------------------------------
> Content-Type: text/plain; charset="us-ascii"; name="Attachment: 1"
> Content-Transfer-Encoding: 7bit
> Content-Description:
> ----------------------------------------
> > ---------------------------(end of broadcast)---------------------------
> > TIP 6: Have you searched our list archives?
> >
> > http://www.postgresql.org/search.mpl
>