Thread: ODBC Patch for OJs/Large Querys & Rows
Hi, I decided to give this a go after all :-) The attached patch does the following but it does *not* check whether the user is connected to PostgreSQL 7.0.x or 7.1 first (as would be required for some of the features) - the driver doesn't do this at all afaik and it's beyond my capabilities to implement such checking in code that doesn't look like it was written by my 1 year old daughter! 1) The driver now reports no maximum query length (SQL_MAX_QUERY_SIZE). 2) The driver now reports no maximum row length (SQL_MAX_ROW_SIZE). 3) The driver now reports that Outer Joins are supported (SQL_OUTER_JOINS), but still does not report oj capabilities (SQL_OJ_CAPABILITIES). 4) The version number has been incremented to 7.1.0000 in psqlodbc.h *and* psqlodbc.rc If someone can clarify which SQL_OJ_CAPABILITIES PostgreSQL supports I should be able to sort that as well. BTW: If this patch gets thrown straight in the bin I won't be offended :-) Regards, Dave.
Attachment
Dave Page <dpage@vale-housing.co.uk> writes: > If someone can clarify which SQL_OJ_CAPABILITIES PostgreSQL supports I > should be able to sort that as well. What are the options? Offhand I think we do everything but UNION JOIN. regards, tom lane
Applied. Nice to see you fixing your own reports. [ Charset ISO-8859-1 unsupported, converting... ] > Hi, > > I decided to give this a go after all :-) The attached patch does the > following but it does *not* check whether the user is connected to > PostgreSQL 7.0.x or 7.1 first (as would be required for some of the > features) - the driver doesn't do this at all afaik and it's beyond my > capabilities to implement such checking in code that doesn't look like it > was written by my 1 year old daughter! > > 1) The driver now reports no maximum query length (SQL_MAX_QUERY_SIZE). > 2) The driver now reports no maximum row length (SQL_MAX_ROW_SIZE). > 3) The driver now reports that Outer Joins are supported (SQL_OUTER_JOINS), > but still does not report oj capabilities (SQL_OJ_CAPABILITIES). > 4) The version number has been incremented to 7.1.0000 in psqlodbc.h *and* > psqlodbc.rc > > If someone can clarify which SQL_OJ_CAPABILITIES PostgreSQL supports I > should be able to sort that as well. > > BTW: If this patch gets thrown straight in the bin I won't be offended :-) > > Regards, > > Dave. > [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> -----Original Message----- > From: Tom Lane [mailto:tgl@sss.pgh.pa.us] > Sent: 24 January 2001 16:51 > To: Dave Page > Subject: Re: [PATCHES] ODBC Patch for OJs/Large Querys & Rows > > > > SQL_OJ_LEFT = Left outer joins are supported. > > Yes. <snip> In addition to my earlier patch, this one adds support for SQLGetInfo SQL_OJ_CAPABILITIES to the ODBC driver. Regards, Dave.