Thread: BeOS Files & diff's

Guys,

Here is the first batch of files and diffs for the BeOS port.  I've run into
problems with some bits of it, but when all the patches are in it'll build
and we can fix it from there :)  I've got a version that builds and runs and
that is the basis for these patches.

[Applied against 7.0 from CVS]

The first file has the new additional files that are required,
    template/beos
    backend/port/dynloader/beos.c
    backend/port/dynloader/beos.h
    include/port/beos.h
    makefiles/Makefile.beos

The second is a tarball of diffs against a few files.  I've added sys/ipc.h
to configure and config.h via configure.in and config.h.in and then started
adding the check as this file isn't needed on BeOS and having loads of
#ifdef BEOS isn't as obvious as #ifdef HAVE_SYS_IPC_H and isn't as
autconf'ish :)
Files touched are
    include/c.h
    configure.in
    include/config.h.in
    include/storage/ipc.h
    include/utils/int8.h

Let me know how these go.  I'll await a response before submitting any more.

Any problems just get in touch.

david


"Do not meddle in the affairs of sysadmins, they are quick to
anger and have no need for subtlety."

David Reid writes:

> Here is the first batch of files and diffs for the BeOS port.

Looks pretty straightforward, just some minor comments. I'd be happy to
help with anything.

Please avoid any #ifdef __BEOS__ etc as much as possible. For example,
there isn't a good reason to do this

+#ifndef __BEOS__
 #ifndef __cplusplus
 #ifndef bool
 typedef char bool;
@@ -80,6 +84,7 @@
 #ifndef false
 #define false  ((bool) 0)
 #endif
+#endif /* __BEOS__ */
 typedef bool *BoolPtr;

unless your compiler is broken.

To include SupportDefs.h, create a configure test for it.

Please no -DBEOS, especially when __BEOS__ seems to be predefined. If you
need to define this to get certain symbols defined in system header files,
do it in configure.in; look at AC_AIX as an example.

Also, please add comments to all platform specific stuff. Why do you
define AF_UNIX to 1? Is it not predefined, or does BEOS have no domain
sockets (in which case you have more work to do)?

Also, patches should usually be formed with diff -cr to get them all into
one file.


--
Peter Eisentraut                  Sernanders väg 10:115
peter_e@gmx.net                   75262 Uppsala
http://yi.org/peter-e/            Sweden