Thread: [psqlODBC 08.02.0401] Typo

[psqlODBC 08.02.0401] Typo

From

Rainer Bauer

Date:

01 June 2007, 10:28:22

Hi,

while browsing the source I found a typo in socket.c::SOCK_Constructor()

Original code:
        if (rv)
            rv->buffer_size =
conn->connInfo.drivers.socket_buffersize;
        else
            rv->buffer_size = globals.socket_buffersize;

But since rv is allocated and checked before, the test should probably be:
        if (conn)
            rv->buffer_size =
conn->connInfo.drivers.socket_buffersize;
        else
            rv->buffer_size = globals.socket_buffersize;

Rainer

Re: [psqlODBC 08.02.0401] Typo

From

Hiroshi Inoue

Date:

01 June 2007, 21:52:56

Rainer Bauer wrote:
> Hi,
>
> while browsing the source I found a typo in socket.c::SOCK_Constructor()
>
> Original code:
>         if (rv)
>             rv->buffer_size =
> conn->connInfo.drivers.socket_buffersize;
>         else
>             rv->buffer_size = globals.socket_buffersize;
>
> But since rv is allocated and checked before, the test should probably be:
>         if (conn)
>             rv->buffer_size =
> conn->connInfo.drivers.socket_buffersize;
>         else
>             rv->buffer_size = globals.socket_buffersize;

Oops you are right.
Thanks.

regards,
Hiroshi Inoue