Thread: [PATCH] initialize pgconn to null

This patch fixes a potential segfault that can happen if a dbc handle is created and then destroyed without attempting
aconnection. 

The problem is that CC_Constructor doesn't initialize this new member variable.

--- connection.c.old    2005-10-24 21:23:55.000000000 -0400
+++ connection.c        2005-10-24 21:16:39.000000000 -0400
@@ -2443,6 +2443,7 @@
                rv->current_schema = NULL;
                rv->num_discardp = 0;
                rv->discardp = NULL;
+                rv->pgconn = NULL;

                /* Initialize statement options to defaults */
                /* Statements under this conn will inherit these options */

Thanks Scot, patch applied.

Regards, Dave

> -----Original Message-----
> From: pgsql-odbc-owner@postgresql.org
> [mailto:pgsql-odbc-owner@postgresql.org] On Behalf Of Scot Loach
> Sent: 25 October 2005 02:29
> To: pgsql-odbc@postgresql.org
> Subject: [ODBC] [PATCH] initialize pgconn to null
>
> This patch fixes a potential segfault that can happen if a
> dbc handle is created and then destroyed without attempting a
> connection.
>
> The problem is that CC_Constructor doesn't initialize this
> new member variable.
>
> --- connection.c.old    2005-10-24 21:23:55.000000000 -0400
> +++ connection.c        2005-10-24 21:16:39.000000000 -0400
> @@ -2443,6 +2443,7 @@
>                 rv->current_schema = NULL;
>                 rv->num_discardp = 0;
>                 rv->discardp = NULL;
> +                rv->pgconn = NULL;
>
>                 /* Initialize statement options to defaults */
>                 /* Statements under this conn will inherit
> these options */
>
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
>