Thread: Re: fixes for psqlodbc-07.03.200, patch

Re: fixes for psqlodbc-07.03.200, patch

From
"Dave Page"
Date:
From: Bruce Momjian
> Here are my updates/fixes for version 07.03.200.
> Details:
> - EINTR safety for send/recv, NOT4WIN
> - init vars before using them (most prominently in
>   dlg_specific.c::SQLGetPrivateProfileString calls),
> - avoid those notorious core dumps when logging on hitting
>   "null" data... in result.c
> - make 07.03.200 work with the new mutex_locks
> - may use -DHAVE_ECO_THREAD_LOCKS, if you use libiodbc (or similar)
>   which already shells every driver call in mutex_locks
> - using the driver (in conjunction w/libiodbc) on Solaris in a
>   threaded environment (thus --enable-pthreads) we also found that
>   -DHAVE_LOCALTIME_R is a good idea, also configure does not auto-
>   link libsocket which is needed anyway... (mind libnsl when not
>   threaded)

Ack! After checking this and massaging it onto CVS tip, it seems that
Hiroshi already applied it on December 9th last year...

Thanks anyway Bruce.

Regards, Dave.

Re: fixes for psqlodbc-07.03.200, patch

From
Bruce Momjian
Date:
Dave Page wrote:
> From: Bruce Momjian
> > Here are my updates/fixes for version 07.03.200.
> > Details:
> > - EINTR safety for send/recv, NOT4WIN
> > - init vars before using them (most prominently in
> >   dlg_specific.c::SQLGetPrivateProfileString calls),
> > - avoid those notorious core dumps when logging on hitting
> >   "null" data... in result.c
> > - make 07.03.200 work with the new mutex_locks
> > - may use -DHAVE_ECO_THREAD_LOCKS, if you use libiodbc (or similar)
> >   which already shells every driver call in mutex_locks
> > - using the driver (in conjunction w/libiodbc) on Solaris in a
> >   threaded environment (thus --enable-pthreads) we also found that
> >   -DHAVE_LOCALTIME_R is a good idea, also configure does not auto-
> >   link libsocket which is needed anyway... (mind libnsl when not
> >   threaded)
>
> Ack! After checking this and massaging it onto CVS tip, it seems that
> Hiroshi already applied it on December 9th last year...
>
> Thanks anyway Bruce.
>

No problem.  Sorry I missed Hiroshi's apply.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073