Thread: MULTIBYTE support
Hi all, In this list there was a posting by Eiji Tokuya about MULTIBYTE patched psqlodbc driver a few days ago. If there's no objection I would like to commit the patch before the release. Note that the changes are all #ifdef'd and doesn't touch existent NON-MULTIBYTE stuff at all. Thanks to Eiji Tokuya for making the patch. Thanks to Hiroki Kataoka for suggestion and discussion with Eiji about its implementation. regards, Hiroshi Inoue
> -----Original Message----- > From: Hiroshi Inoue [mailto:Inoue@tpf.co.jp] > Sent: 13 March 2001 10:01 > To: pgsql-odbc@postgresql.org > Subject: [ODBC] MULTIBYTE support > > > Hi all, > > In this list there was a posting by Eiji Tokuya > about MULTIBYTE patched psqlodbc driver a few > days ago. If there's no objection I would like > to commit the patch before the release. Note that > the changes are all #ifdef'd and doesn't touch > existent NON-MULTIBYTE stuff at all. > > Thanks to Eiji Tokuya for making the patch. > Thanks to Hiroki Kataoka for suggestion and > discussion with Eiji about its implementation. I have no objections to adding it but I do think a revision number increment to 07.01.0004 would be a good idea as well though. I can submit a patch for that or if you (Hiroshi) can edit psqlodbc.rc (in 3 places?) and psqlodbc.h? Let me know if you want me to do it... Regards, Dave.
Dave Page wrote: > > > In this list there was a posting by Eiji Tokuya > > about MULTIBYTE patched psqlodbc driver a few > > days ago. If there's no objection I would like > > to commit the patch before the release. Note that > > the changes are all #ifdef'd and doesn't touch > > existent NON-MULTIBYTE stuff at all. > > > > Thanks to Eiji Tokuya for making the patch. > > Thanks to Hiroki Kataoka for suggestion and > > discussion with Eiji about its implementation. > > I have no objections to adding it but I do think a revision number increment > to 07.01.0004 would be a good idea as well though. I can submit a patch for > that or if you (Hiroshi) can edit psqlodbc.rc (in 3 places?) and psqlodbc.h? > Let me know if you want me to do it... > Eiji is changing win32.mak(it's not !IFDEF'd) now. Probably he would change the revision number together according to your suggestion. Thanks. Hiroshi Inoue
Hi
I committed the following change.
Now psqlodbc version is 7.01.0004.
Add multibyte support.
Provide an extenisible scheme of encoding conversion.
As the first step, SJIS and BIG5 are supported.
From now on multibyte people would be happy to use
this psqlodbc driver.
Eiji Tokuya e-tokuya@mail.sankyo-unyu.co.jp
regards,
Hiroshi Inoue
>
> Dave Page wrote:
> >
> > > In this list there was a posting by Eiji Tokuya
> > > about MULTIBYTE patched psqlodbc driver a few
> > > days ago. If there's no objection I would like
> > > to commit the patch before the release. Note that
> > > the changes are all #ifdef'd and doesn't touch
> > > existent NON-MULTIBYTE stuff at all.
> > >
> > > Thanks to Eiji Tokuya for making the patch.
> > > Thanks to Hiroki Kataoka for suggestion and
> > > discussion with Eiji about its implementation.
> >
> > I have no objections to adding it but I do think a revision number increment
> > to 07.01.0004 would be a good idea as well though. I can submit a patch for
> > that or if you (Hiroshi) can edit psqlodbc.rc (in 3 places?) and psqlodbc.h?
> > Let me know if you want me to do it...
> >
>
> -----Original Message----- > From: Hiroshi Inoue [mailto:Inoue@tpf.co.jp] > Sent: 21 March 2001 09:45 > To: Dave Page; pgsql-odbc@postgresql.org > Subject: Re: [ODBC] MULTIBYTE support > > > Hi > > I committed the following change. > Now psqlodbc version is 7.01.0004. > > Add multibyte support. > Provide an extenisible scheme of encoding conversion. > As the first step, SJIS and BIG5 are supported. > From now on multibyte people would be happy to use > this psqlodbc driver. > > Eiji Tokuya e-tokuya@mail.sankyo-unyu.co.jp > > regards, > Hiroshi Inoue Thanks for letting me know Hiroshi, I'll compile a couple of binaries and make them available for people to download shortly. The attached patch fixes win32.mak which got broken by the Multibyte mod :-(, and tidies it up a little as well. Regards, Dave.
Attachment
> -----Original Message----- > From: Dave Page [mailto:dpage@vale-housing.co.uk] > > > > > Hi > > > > I committed the following change. > > Now psqlodbc version is 7.01.0004. > > > > Add multibyte support. > > Provide an extenisible scheme of encoding conversion. > > As the first step, SJIS and BIG5 are supported. > > From now on multibyte people would be happy to use > > this psqlodbc driver. > > > > Eiji Tokuya e-tokuya@mail.sankyo-unyu.co.jp > > > > regards, > > Hiroshi Inoue > > Thanks for letting me know Hiroshi, I'll compile a couple of binaries and > make them available for people to download shortly. > > The attached patch fixes win32.mak which got broken by the Multibyte mod > :-(, and tidies it up a little as well. > Oops sorry. Applied your patch. Thanks. Hiroshi Inoue