Thread: JDBC build broken by commit 9f9019b

On 08/20/2014 08:27 AM, Michael Paquier wrote:
> Hi all,
>
> Since commit 9f9019b that has been merged yesterday into master, build
> of pgjdbc is broken.

Taking a look now. Odd - did I fail to push a final fixup before the merge?

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

On 08/20/2014 11:43 AM, Craig Ringer wrote:
> Taking a look now. Odd - did I fail to push a final fixup before the merge?

Confirmed - yet I'm confused, as I'm pretty sure I remember Travis
passing with this, and just not updating the github issue. It was a
while ago.

Upon examining my local history, it looks like a case of "Oh, I should
also make this one minor fix that can't break anything just before I push".

Right.

I've pushed a fix.







BTW, I had to apply the attached diff to get the driver to build with my
ant 1.9.2, packaged in Fedora 20 .

The usual approach of popping maven-ant-tasks.jar in lib/ and running:

  ant -lib lib

or

  ant -lib lib/maven-ant-tasks.jar

was not effective, and still failed with:

$ ant -lib lib clean
Buildfile: /home/craig/projects/pgjdbc/build.xml

BUILD FAILED
/home/craig/projects/pgjdbc/build.xml:110: Problem: failed to create
task or type antlib:org.apache.maven.artifact.ant:dependencies
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have taken place.
No types or tasks have been defined in this namespace yet

This appears to be an antlib declaration.
Action: Check that the implementing library exists in one of:
        -/usr/share/ant/lib
        -/home/craig/.ant/lib
        -a directory added on the command line with the -lib argument


... even though:


ant -lib lib clean -diagnostics

showed that maven-ant-tasks.jar was on the classpath, and unpacking the
jar showed that it contained the required antlib.xml that ant -v was
looking for:

[antlib:org.apache.maven.artifact.ant] Could not load definitions from
resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.


Weird. I don't think I had this issue last time around.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

This was blocking my pull request (#180), too. Do I need to do anything or will it be tried again automatically?

Christian

Am 20.08.2014 um 06:20 schrieb Craig Ringer <craig@2ndquadrant.com>:

> On 08/20/2014 11:43 AM, Craig Ringer wrote:
>> Taking a look now. Odd - did I fail to push a final fixup before the merge?
>
> Confirmed - yet I'm confused, as I'm pretty sure I remember Travis
> passing with this, and just not updating the github issue. It was a
> while ago.
>
> Upon examining my local history, it looks like a case of "Oh, I should
> also make this one minor fix that can't break anything just before I push".
>
> Right.
>
> I've pushed a fix.
>
>
>
>
>
>
>
> BTW, I had to apply the attached diff to get the driver to build with my
> ant 1.9.2, packaged in Fedora 20 .
>
> The usual approach of popping maven-ant-tasks.jar in lib/ and running:
>
>  ant -lib lib
>
> or
>
>  ant -lib lib/maven-ant-tasks.jar
>
> was not effective, and still failed with:
>
> $ ant -lib lib clean
> Buildfile: /home/craig/projects/pgjdbc/build.xml
>
> BUILD FAILED
> /home/craig/projects/pgjdbc/build.xml:110: Problem: failed to create
> task or type antlib:org.apache.maven.artifact.ant:dependencies
> Cause: The name is undefined.
> Action: Check the spelling.
> Action: Check that any custom tasks/types have been declared.
> Action: Check that any <presetdef>/<macrodef> declarations have taken place.
> No types or tasks have been defined in this namespace yet
>
> This appears to be an antlib declaration.
> Action: Check that the implementing library exists in one of:
>        -/usr/share/ant/lib
>        -/home/craig/.ant/lib
>        -a directory added on the command line with the -lib argument
>
>
> ... even though:
>
>
> ant -lib lib clean -diagnostics
>
> showed that maven-ant-tasks.jar was on the classpath, and unpacking the
> jar showed that it contained the required antlib.xml that ant -v was
> looking for:
>
> [antlib:org.apache.maven.artifact.ant] Could not load definitions from
> resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
>
>
> Weird. I don't think I had this issue last time around.
>
> --
> Craig Ringer                   http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
> <build.xml.diff>
> --
> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-jdbc

On 08/20/2014 08:10 PM, Stephen Nelson wrote:
> This has been reported by another user of Fedora but I was unable to
> recreate myself. Could you confirm the jar isn't corrupted in any way by
> running:
>
> jar tf lib/maven-ant-tasks-2.1.3.jar
>
> Stephen

No errors.

For comparison:

$ md5sum lib/maven-ant-tasks-2.1.3.jar
7ce48382d1aa4138027a58ec2f29beda  lib/maven-ant-tasks-2.1.3.jar
$ jar tf lib/maven-ant-tasks-2.1.3.jar | wc -l
975
$ du -b lib/maven-ant-tasks-2.1.3.jar
1316000 lib/maven-ant-tasks-2.1.3.jar

with:

$ ant -version
Apache Ant(TM) version 1.9.2 compiled on September 12 2013

$ lsb_release  -a
LSB Version:

:core-4.1-amd64:core-4.1-ia32:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-ia32:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-ia32:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
Distributor ID: Fedora
Description:    Fedora release 20 (Heisenbug)
Release:        20
Codename:       Heisenbug

$ java -version
java version "1.7.0_65"
OpenJDK Runtime Environment (fedora-2.5.1.3.fc20-x86_64 u65-b17)
OpenJDK 64-Bit Server VM (build 24.65-b04, mixed mode)

$ rpm -q ant
ant-1.9.2-7.fc20.noarch

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services