Thread: Patch adding name for NotImplemented

Patch adding name for NotImplemented

From
"Xavier Poinsard"
Date:
I had some time in the train, so here is a patch adding function name to
  notImplemented().
At least it could be help find what function Crystal Report is calling.

Attachment

Re: Patch adding name for NotImplemented

From
Kris Jurka
Date:

On Fri, 11 Feb 2005, Xavier Poinsard wrote:

> I had some time in the train, so here is a patch adding function name to
>   notImplemented().

It seems reather inconsistent, it uses all of the following description
types:
 - Blob.truncate
 - setBinaryStream
 - getArray With Map
 - fetch(ResultCursor, ResultHandler, int)

These need to be consistent.  Also some of the claims are inaccurate, for
example Statement.setURL, Statement.getURL are actually from
PreparedStatement and CallableStatement respectively.

Finally this patch doesn't actually have a change to Driver.notImplemented
to make it work.

Kris Jurka

Re: Patch adding name for NotImplemented

From
"Xavier Poinsard"
Date:
Kris Jurka wrote:
>
> On Fri, 11 Feb 2005, Xavier Poinsard wrote:
>
>
>>I had some time in the train, so here is a patch adding function name to
>>  notImplemented().
>
>
> It seems reather inconsistent, it uses all of the following description
> types:
>  - Blob.truncate
>  - setBinaryStream
>  - getArray With Map
>  - fetch(ResultCursor, ResultHandler, int)

Yes, I changed my mind during the process. I will try to clear some issues.

One problem is that the Exception is sometime used not for an entire
function but only when the function is used with a particular argument.
Other functions with same names are only implement with some sets of
arguments.

Would you prefer the full version :

Interface.functionname(type1,type2) ?

>
> These need to be consistent.  Also some of the claims are inaccurate, for
> example Statement.setURL, Statement.getURL are actually from
> PreparedStatement and CallableStatement respectively.

It will require additional work since I will have to look not only in
the code.

>
> Finally this patch doesn't actually have a change to Driver.notImplemented
> to make it work.

Oops, I missed Driver.java.in.

>
> Kris Jurka
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
>       subscribe-nomail command to majordomo@postgresql.org so that your
>       message can get through to the mailing list cleanly
>


Re: Patch adding name for NotImplemented

From
"Xavier Poinsard"
Date:
Kris Jurka wrote:
> It seems reather inconsistent, it uses all of the following description
> types:
>  - Blob.truncate
>  - setBinaryStream
>  - getArray With Map
>  - fetch(ResultCursor, ResultHandler, int)
>
> These need to be consistent.  Also some of the claims are inaccurate, for
> example Statement.setURL, Statement.getURL are actually from
> PreparedStatement and CallableStatement respectively.
>
> Finally this patch doesn't actually have a change to Driver.notImplemented
> to make it work.

All should be coherent now with full class name (the real implementation
class) and function name (real) with the types of the arguments.
I added some debug calls for special cases where the function is
partially implemented. The use of this.getClass() should help avoiding
excess size for the driver.

Attachment

Re: Patch adding name for NotImplemented

From
Kris Jurka
Date:

On Mon, 14 Feb 2005, Xavier Poinsard wrote:

> [here's a patch to add info to the notImplemented exception]

Applied to 8.0 and HEAD.

Kris Jurka