Thread: patch for close connection bug

patch for close connection bug

From
Thomas O'Dowd
Date:
Hi all,

I noticed that if you shutdown the postmaster while you are connected to
it, if you try to close the connection (it throws an exception which is
expected) but if you call isClosed() on the connection afterwards it
still appears to be open as pg_stream is never set to null. The
following small patch fixes that.

Would be nice to have it in for beta of 7.3.

Cheers,

Tom.
--
Thomas O'Dowd. - Nooping - http://nooper.com
tom@nooper.com - Testing - http://nooper.co.jp/labs

Attachment

Re: patch for close connection bug

From
Dave Cramer
Date:
Patch applied,

Thanks,
Dave
On Fri, 2002-08-30 at 22:23, Thomas O'Dowd wrote:
> Hi all,
>
> I noticed that if you shutdown the postmaster while you are connected to
> it, if you try to close the connection (it throws an exception which is
> expected) but if you call isClosed() on the connection afterwards it
> still appears to be open as pg_stream is never set to null. The
> following small patch fixes that.
>
> Would be nice to have it in for beta of 7.3.
>
> Cheers,
>
> Tom.
> --
> Thomas O'Dowd. - Nooping - http://nooper.com
> tom@nooper.com - Testing - http://nooper.co.jp/labs
> ----
>

> Index: org/postgresql/jdbc1/AbstractJdbc1Connection.java
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java,v
> retrieving revision 1.5
> diff -c -r1.5 AbstractJdbc1Connection.java
> *** org/postgresql/jdbc1/AbstractJdbc1Connection.java    2002/08/23 20:45:49
> 1.5
> --- org/postgresql/jdbc1/AbstractJdbc1Connection.java    2002/08/31 02:14:40
> ***************
> *** 776,782 ****
>                           }
>                           catch (IOException e)
>                           {}
> !                         pg_stream = null;
>                   }
>           }
>
> --- 776,785 ----
>                           }
>                           catch (IOException e)
>                           {}
> !                         finally
> !                         {
> !                                 pg_stream = null;
> !                         }
>                   }
>           }
>
> ----
>

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly