Thread: Numeric decimal digits and radix to DatabaseMetaData.getColumns()

Numeric decimal digits and radix to DatabaseMetaData.getColumns()

From
Vicktor
Date:
Hello All,

I have little patch for postgres jdbc2.
This interesting thing was fund in ./postgresql-7.1.3/src/backend/utils/adt/format_type.c line 167

Best regards,
Victor Gluschenko
---------------------
 ADV / web-engineering co.
 mailto:viс@adv.ru

Attachment

Re: Numeric decimal digits and radix to DatabaseMetaData.getColumns()

From
Bruce Momjian
Date:
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours, with JDBC maintainers
approval.


---------------------------------------------------------------------------


Vicktor wrote:
> Hello All,
>
> I have little patch for postgres jdbc2.
> This interesting thing was fund in ./postgresql-7.1.3/src/backend/utils/adt/format_type.c line 167
>
> Best regards,
> Victor Gluschenko
> ---------------------
>  ADV / web-engineering co.
>  mailto:vi?@adv.ru

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Numeric decimal digits and radix to DatabaseMetaData.getColumns()

From
Bruce Momjian
Date:
Patch applied.  Thanks.

---------------------------------------------------------------------------


Vicktor wrote:
> Hello All,
>
> I have little patch for postgres jdbc2.
> This interesting thing was fund in ./postgresql-7.1.3/src/backend/utils/adt/format_type.c line 167
>
> Best regards,
> Victor Gluschenko
> ---------------------
>  ADV / web-engineering co.
>  mailto:vi?@adv.ru

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Status of outstanding patches

From
"Dave Cramer"
Date:
Ok,

I have applied all but 3 of the patches found at
http://candle.pha.pa.us/cgi-bin/pgpatches

The ones left are

1) Connection clean up
2) Result.next throws NullPointerException
3) CStmt patch

I need more time to review 1 and 3, and I may do 2 a different way. It
would make more sense to call a method to check for a number of things
since this is called in many places. However the patch supplied with 2
above does this inline which obviously would be a little faster.

Any comments on either approach.

As I mentioned there are some patches which are not on the list; one in
particular is the connection pool patch which I have, but haven't looked
at yet.

Dave


Re: Numeric decimal digits and radix to DatabaseMetaData.getColumns()

From
"Anthony Kwok"
Date:
What is the patch exactly fixed? I suspect there is a bug in my program which is affected by this patch. 

Thanks
Anthony

> -----Original Message-----
> From: pgsql-jdbc-owner@postgresql.org 
> [mailto:pgsql-jdbc-owner@postgresql.org]On Behalf Of Bruce Momjian
> Sent: Tuesday, March 05, 2002 11:36 AM
> To: Vicktor
> Cc: pgsql-jdbc@postgresql.org
> Subject: Re: [JDBC] Numeric decimal digits and radix to 
> DatabaseMetaData.getColumns()
> 
> 
> 
> Patch applied.  Thanks.
> 

Re: Status of outstanding patches

From
Bruce Momjian
Date:
Thanks.  This is a great help.  I am working on applying/rejecting the
remaining ones.


---------------------------------------------------------------------------

Dave Cramer wrote:
> Ok,
>
> I have applied all but 3 of the patches found at
> http://candle.pha.pa.us/cgi-bin/pgpatches
>
> The ones left are
>
> 1) Connection clean up
> 2) Result.next throws NullPointerException
> 3) CStmt patch
>
> I need more time to review 1 and 3, and I may do 2 a different way. It
> would make more sense to call a method to check for a number of things
> since this is called in many places. However the patch supplied with 2
> above does this inline which obviously would be a little faster.
>
> Any comments on either approach.
>
> As I mentioned there are some patches which are not on the list; one in
> particular is the connection pool patch which I have, but haven't looked
> at yet.
>
> Dave
>
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Numeric decimal digits and radix to DatabaseMetaData.getColumns()

From
"Dave Cramer"
Date:
It returns the correct information wrt to base, and decimals about
numeric columns.

Dave

-----Original Message-----
From: pgsql-jdbc-owner@postgresql.org
[mailto:pgsql-jdbc-owner@postgresql.org] On Behalf Of Anthony Kwok
Sent: Monday, March 04, 2002 11:01 PM
To: Bruce Momjian
Cc: pgsql-jdbc@postgresql.org
Subject: Re: [JDBC] Numeric decimal digits and radix to
DatabaseMetaData.getColumns()


What is the patch exactly fixed? I suspect there is a bug in my program
which is affected by this patch.

Thanks
Anthony

> -----Original Message-----
> From: pgsql-jdbc-owner@postgresql.org
> [mailto:pgsql-jdbc-owner@postgresql.org]On Behalf Of Bruce Momjian
> Sent: Tuesday, March 05, 2002 11:36 AM
> To: Vicktor
> Cc: pgsql-jdbc@postgresql.org
> Subject: Re: [JDBC] Numeric decimal digits and radix to
> DatabaseMetaData.getColumns()
>
>
>
> Patch applied.  Thanks.
>

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org