Thread: [Fwd: Re: A Bug Fix - Is this a real bug? Has this already been fixed?]

JDBC'ers,

Can we go ahead and apply the patch to the jdbc2 (its only been applied
to jdbc1)

This has been discussed previously (archives) and in fact the patch was
to be applied - but the sources say otherwise.

Glenn

-----Forwarded Message-----

From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Glenn R. Kronschnabl <grk@netquotient.com>
Subject: Re: [JDBC] A Bug Fix - Is this a real bug? Has this already been  fixed?
Date: 13 Sep 2001 11:46:50 -0500


I would ask this in jdbc.  I see jdbc1 has some test for 't' and 'T' and
'1', but not in jdbc2.  The following patch should fix it.  If the jdbc
mailing list doesn't object, I will apply this soon.

> Hi,
>
> I was searching the postgresql archives and came across:
>
> Author: Bruce Momjian <pgman@candle.pha.pa.us>
> Date: Wed 16 May 12:31:26 2001 EDT
> Subject: Re: [JDBC] A Bug Fix - Is this a real bug? Has this already
> been fixed?
>
> This thread talks about fixing the getBoolean(...) method so that
> besides 't' or 'T', we can also use 0 or 1.
>
> Looking at the sources, it doesn't look like this patch was ever
> applied.  I just looked at the 7.1.3 sources as well as the latest
> snapshot, and it hasn't been changed.
>
> What gives?
>
> Thanks,
> Glenn
>
>
>
>
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania
19026

----


Index: src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java,v
retrieving revision 1.33
diff -c -r1.33 ResultSet.java
*** src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java    2001/09/10 15:07:05    1.33
--- src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java    2001/09/13 16:43:51
***************
*** 1396,1402 ****
          if (s != null)
          {
              int c = s.charAt(0);
!             return ((c == 't') || (c == 'T'));
          }
          return false;        // SQL NULL
      }
--- 1396,1402 ----
          if (s != null)
          {
              int c = s.charAt(0);
!             return ((c == 't') || (c == 'T') || (c == '1'));
          }
          return false;        // SQL NULL
      }