Thread: Merging JDBC1 and JDBC2 similarities

Merging JDBC1 and JDBC2 similarities

From
Anders Bengtsson
Date:
This patch merges the identical methods from the JDBC1 and JDBC2
connection implementations (org.postgresql.jdbc[1|2].Connection) into
their superclass (org.postgresql.Connection).

It also changes the close() methods of Connection and PG_Stream, so that
PG_Stream no longer is responsible for sending the termination packet 'X'
to the backend. I figured that protocol-level stuff like that belonged in
Connection more than in PG_Stream.

/Anders
_____________________________________________________________________
A n d e r s  B e n g t s s o n                   ndrsbngtssn@yahoo.se
Stockholm, Sweden

Attachment

Re: [PATCHES] Merging JDBC1 and JDBC2 similarities

From
Bruce Momjian
Date:
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.


>
> This patch merges the identical methods from the JDBC1 and JDBC2
> connection implementations (org.postgresql.jdbc[1|2].Connection) into
> their superclass (org.postgresql.Connection).
>
> It also changes the close() methods of Connection and PG_Stream, so that
> PG_Stream no longer is responsible for sending the termination packet 'X'
> to the backend. I figured that protocol-level stuff like that belonged in
> Connection more than in PG_Stream.
>
> /Anders
> _____________________________________________________________________
> A n d e r s  B e n g t s s o n                   ndrsbngtssn@yahoo.se
> Stockholm, Sweden

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://www.postgresql.org/search.mpl

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: [PATCHES] Merging JDBC1 and JDBC2 similarities

From
Bruce Momjian
Date:
Patch applied.  Thanks.

>
> This patch merges the identical methods from the JDBC1 and JDBC2
> connection implementations (org.postgresql.jdbc[1|2].Connection) into
> their superclass (org.postgresql.Connection).
>
> It also changes the close() methods of Connection and PG_Stream, so that
> PG_Stream no longer is responsible for sending the termination packet 'X'
> to the backend. I figured that protocol-level stuff like that belonged in
> Connection more than in PG_Stream.
>
> /Anders
> _____________________________________________________________________
> A n d e r s  B e n g t s s o n                   ndrsbngtssn@yahoo.se
> Stockholm, Sweden

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://www.postgresql.org/search.mpl

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026