Thread: [PATCH] setTimestamp(int, Timestamp) fails on null timestamp

[PATCH] setTimestamp(int, Timestamp) fails on null timestamp

From
"Dejan Vucinic"
Date:
Greetings,

The 7.1.2 JDBC driver has a bug in setTimestamp(int, Timestamp), it
throws a NullPointerException if the Timestamp is set to null.
Looking at the code, this seems to be the case for the other form
of setTimestamp as well, in both jdbc1/PreparedStatement.java and
jdbc2/PreparedStatement.java.  Please insert something like this at
the very beginning of the four methods:

          if (null == x) {
            set(parameterIndex, "NULL");
            return;
          }

Thanks,

--dv

_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com


RE: [PATCH] setTimestamp(int, Timestamp) fails on null timestamp

From
"Dave Cramer"
Date:
Dejan,

This has already been done in cvs, please get the binaries from

http://jdbc.fastcrypt.com

Dave

-----Original Message-----
From: pgsql-jdbc-owner@postgresql.org
[mailto:pgsql-jdbc-owner@postgresql.org] On Behalf Of Dejan Vucinic
Sent: July 11, 2001 5:43 PM
To: pgsql-jdbc@postgresql.org
Subject: [JDBC] [PATCH] setTimestamp(int, Timestamp) fails on null
timestamp


Greetings,

The 7.1.2 JDBC driver has a bug in setTimestamp(int, Timestamp), it
throws a NullPointerException if the Timestamp is set to null. Looking
at the code, this seems to be the case for the other form of
setTimestamp as well, in both jdbc1/PreparedStatement.java and
jdbc2/PreparedStatement.java.  Please insert something like this at the
very beginning of the four methods:

          if (null == x) {
            set(parameterIndex, "NULL");
            return;
          }

Thanks,

--dv

_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com


---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster



RE: [PATCH] setTimestamp(int, Timestamp) fails on null timestamp

From
"Dejan Vucinic"
Date:
Dave,

>This has already been done in cvs, please get the binaries from
>http://jdbc.fastcrypt.com

I just downloaded jdbc7.1-1.3.jar and I'm still seeing the same
problem:

java.lang.NullPointerException
    at
org.postgresql.jdbc2.PreparedStatement.setTimestamp(PreparedStatement.java:381)

My decompiler shows essentially the same code as the one in the
7.1.2 bundle (I didn't set up CVS yet, Windows-bound, more trouble
than it's worth, etc. :).

Thanks,

--dv

_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com


RE: [PATCH] setTimestamp(int, Timestamp) fails on null timestamp

From
"Dave Cramer"
Date:
Dejan,

Yes you are correct, I will submit a patch shortly.

Dave

-----Original Message-----
From: Dejan Vucinic [mailto:hotdejan@hotmail.com]
Sent: July 11, 2001 7:20 PM
To: Dave@micro-automation.net; pgsql-jdbc@postgresql.org
Subject: RE: [JDBC] [PATCH] setTimestamp(int, Timestamp) fails on null
timestamp


Dave,

>This has already been done in cvs, please get the binaries from
>http://jdbc.fastcrypt.com

I just downloaded jdbc7.1-1.3.jar and I'm still seeing the same
problem:

java.lang.NullPointerException
    at
org.postgresql.jdbc2.PreparedStatement.setTimestamp(PreparedStatement.ja
va:381)

My decompiler shows essentially the same code as the one in the 7.1.2
bundle (I didn't set up CVS yet, Windows-bound, more trouble than it's
worth, etc. :).

Thanks,

--dv

_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com