Thread: Re: [PATCHES] Patch for jdbc Makefile
Any JDBC people want to comment on this? > Hi all! > > Attached is a small patch for src/interfaces/jdbc/Makefile. It sets > the CLASSPATH to "." before running javac and also before running > 'java utils.CheckVersion'; otherwise, the user must do this themselves > or get "class not found" error messages. > > The patch is applied by > > patch < patch.Makefile > > run in src/interfaces/jdbc. > > William > -- > William Webber william@peopleweb.net.au > Senior Programmer > PeopleWeb Australia http://www.peopleweb.com [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Quoting Bruce Momjian <pgman@candle.pha.pa.us>: > > Any JDBC people want to comment on this? Makefile is obsolete in 7.1, as is CheckVersion ;-) > > > Hi all! > > > > Attached is a small patch for src/interfaces/jdbc/Makefile. It sets > > the CLASSPATH to "." before running javac and also before running > > 'java utils.CheckVersion'; otherwise, the user must do this > themselves > > or get "class not found" error messages. > > > > The patch is applied by > > > > patch < patch.Makefile > > > > run in src/interfaces/jdbc. > > > > William > > -- > > William Webber william@peopleweb.net.au > > Senior Programmer > > PeopleWeb Australia http://www.peopleweb.com > > [ Attachment, skipping... ] > > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 853-3000 > + If your life is a hard drive, | 830 Blythe Avenue > + Christ can be your backup. | Drexel Hill, Pennsylvania > 19026 > -- Peter Mount peter@retep.org.uk PostgreSQL JDBC Driver: http://www.retep.org.uk/postgres/ RetepPDF PDF library for Java: http://www.retep.org.uk/pdf/
On Thu, 25 Jan 2001, Peter T Mount wrote:
> Quoting Bruce Momjian <pgman@candle.pha.pa.us>:
>
> >
> > Any JDBC people want to comment on this?
>
> Makefile is obsolete in 7.1, as is CheckVersion ;-)
Makefile is still part of the 7.1.x CVS tree, though...
Are you intending on ditching the Makefile completely and opting for an
ant-only Java build?
I'm still using the Makefile, but it would not bother me to switch to ant
if that's the way it will be, and ant will be more robust.
However, I'm confused by what is probably a documentation bug concerning
java.lang.Byte in the build.xml file. Should this bit of documentation be
updated? The code does not appear to deal with java.lang.Byte at all.
<!--
This is a simpler method than utils.CheckVersion
It defaults to jdbc1, but builds jdbc2 if the java.lang.Byte class is
in the CLASSPATH (ie JDK1.2 or later), and then enterprise if the
javax.sql.DataSource class is present.
Important: This must have the following order: jdbc1, jdbc2, enterprise
-->
<target name="check_versions">
<available property="jdk1.2+" classname="java.lang.ThreadLocal" />
<available property="jdk1.3+" classname="java.lang.StrictMath" />
<available property="jdk1.2e+" classname="javax.sql.DataSource" />
</target>
--
Richard Bullington-McGuire <rbulling@microstate.com>
Chief Technology Officer, The Microstate Corporation
Phone: 703-796-6446 URL: http://www.microstate.com/
PGP key IDs: RSA: 0x93862305 DH/DSS: 0xDAC3028E
Quoting Richard Bullington-McGuire <rbulling@microstate.com>: > On Thu, 25 Jan 2001, Peter T Mount wrote: > > > Quoting Bruce Momjian <pgman@candle.pha.pa.us>: > > > > > > > > Any JDBC people want to comment on this? > > > > Makefile is obsolete in 7.1, as is CheckVersion ;-) > > Makefile is still part of the 7.1.x CVS tree, though... > Are you intending on ditching the Makefile completely and opting for an > ant-only Java build? Yes. I've left it in there for now, but I've been debating on if we should remove it completely for 7.1. Personally I think we should, but I didn't want to hit everyone without fair warning. > > I'm still using the Makefile, but it would not bother me to switch to > ant if that's the way it will be, and ant will be more robust. It's way more robust. In fact I'm looking at getting configure to detect ant and get the top level makefile to run it as part of the main build. Also, our build.xml files also support installation, so "make install" can install the .jar files into the PG_LIB directory. > > However, I'm confused by what is probably a documentation bug > concerning > java.lang.Byte in the build.xml file. Should this bit of documentation > be > updated? The code does not appear to deal with java.lang.Byte at all. Yes. No time for 7.1 for this, but I was thinking of splitting the monolithic jdbc.sgml file up, as there's a lot of outdated stuff in it, and a lot of undocumented stuff to go into it. You haven't seen the stuff I'm donating into /contrib yet ;-) Peter -- Peter Mount peter@retep.org.uk PostgreSQL JDBC Driver: http://www.retep.org.uk/postgres/ RetepPDF PDF library for Java: http://www.retep.org.uk/pdf/