Postgres Pro
Downloads
Home   >   mailing lists

Thread: Parallel indicators not written by pg_get_functiondef

Parallel indicators not written by pg_get_functiondef

From
Feike Steenbergen
Date:
pg_get_functiondef(oid) does not return the PARALLEL indicators.

Attached a small patch to have pg_get_functiondef actually add these indicators, using commit 7aea8e4f2 (pg_dump.c) as a guide.

The logic is the same as with the volatility: we only append non-default indicators.

Feike Steenbergen
Attachment

Re: Parallel indicators not written by pg_get_functiondef

From
Michael Paquier
Date:
On Fri, Apr 15, 2016 at 8:48 PM, Feike Steenbergen
<feikesteenbergen@gmail.com> wrote:
> pg_get_functiondef(oid) does not return the PARALLEL indicators.
>
> Attached a small patch to have pg_get_functiondef actually add these
> indicators, using commit 7aea8e4f2 (pg_dump.c) as a guide.
>
> The logic is the same as with the volatility: we only append non-default
> indicators.

+1 for a good catch. Your patch is correct.
-- 
Michael

Re: Parallel indicators not written by pg_get_functiondef

From
Feike Steenbergen
Date:
This patch is redundant as of commit 2ac3be2e763d9b971352819f285dd51519e0aeb9

(Ashutosh Sharma diagnosed and patched the same problem)

On 15 April 2016 at 14:13, Michael Paquier <michael.paquier@gmail.com> wrote:
On Fri, Apr 15, 2016 at 8:48 PM, Feike Steenbergen
<feikesteenbergen@gmail.com> wrote:
> pg_get_functiondef(oid) does not return the PARALLEL indicators.
>
> Attached a small patch to have pg_get_functiondef actually add these
> indicators, using commit 7aea8e4f2 (pg_dump.c) as a guide.
>
> The logic is the same as with the volatility: we only append non-default
> indicators.

+1 for a good catch. Your patch is correct.
--
Michael

Re: Parallel indicators not written by pg_get_functiondef

From
Robert Haas
Date:
On Wed, Apr 27, 2016 at 3:02 AM, Feike Steenbergen
<feikesteenbergen@gmail.com> wrote:
> This patch is redundant as of commit
> 2ac3be2e763d9b971352819f285dd51519e0aeb9
>
> (Ashutosh Sharma diagnosed and patched the same problem)

Oops.  I completely failed to notice this prior report.

Sorry about that.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company