Thread: Automatically add -Wold-style-definition?
Hi, Does somebody see a reason not to automatically detect and use -Wold-style-definition? Per e.g. http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=9f7c527af308dcdaba2f0ff9d362d672e8886fb1 that'd be useful, and it's an easy to make and automatically detect mistake; and it doesn't have false positives. Greetings, Andres Freund
Andres Freund <andres@anarazel.de> writes: > Does somebody see a reason not to automatically detect and use > -Wold-style-definition? +1 ... unless we have some that are that way intentionally, which I kinda doubt, but you could soon find out. regards, tom lane
On 2016-03-27 17:16:11 -0400, Tom Lane wrote: > Andres Freund <andres@anarazel.de> writes: > > Does somebody see a reason not to automatically detect and use > > -Wold-style-definition? > > +1 ... unless we have some that are that way intentionally, which > I kinda doubt, but you could soon find out. We don't, I've been running with it enabled for a long while (which is how I found issue pointed out upthread). Andres