Thread: Manual bitswizzling -> LOCKBIT_ON

Manual bitswizzling -> LOCKBIT_ON

From
Thomas Munro
Date:
Hi

While studying lmgr code, I noticed that there are a couple of places
that use 1 << x to convert a LOCKMODE to a LOCKMASK instead of the
macro that is used elsewhere.  Should that be changed for consistency,
as in the attached?

--
Thomas Munro
http://www.enterprisedb.com

Attachment

Re: Manual bitswizzling -> LOCKBIT_ON

From
Robert Haas
Date:
On Thu, Sep 24, 2015 at 10:24 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> While studying lmgr code, I noticed that there are a couple of places
> that use 1 << x to convert a LOCKMODE to a LOCKMASK instead of the
> macro that is used elsewhere.  Should that be changed for consistency,
> as in the attached?

Sure, why not?

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company