Thread: [PATCH] Add missing \ddp psql command
Quickie patch for spotted missing psql \ddp tab-completion. -- David Christensen PostgreSQL Team Manager End Point Corporation david@endpoint.com 785-727-1171
Attachment
On Tue, Jul 7, 2015 at 2:11 AM, David Christensen <david@endpoint.com> wrote: > Quickie patch for spotted missing psql \ddp tab-completion. Thanks for the report and patch! I found that tab-completion was not supported in not only \ddp but also other psql meta commands like \dE, \dm, \dO, \dy, \s and \setenv. Attached patch adds all those missing tab-completions. Thought? Regards, -- Fujii Masao
Attachment
> On Jul 7, 2015, at 3:53 AM, Fujii Masao <masao.fujii@gmail.com> wrote: > > On Tue, Jul 7, 2015 at 2:11 AM, David Christensen <david@endpoint.com> wrote: >> Quickie patch for spotted missing psql \ddp tab-completion. > > Thanks for the report and patch! > > I found that tab-completion was not supported in not only \ddp > but also other psql meta commands like \dE, \dm, \dO, \dy, \s and > \setenv. Attached patch adds all those missing tab-completions. From a completeness standpoint makes sense to me to have all of them, but from a practical standpoint a single-charactercompletion like \s isn’t going to do much. :) David -- David Christensen PostgreSQL Team Manager End Point Corporation david@endpoint.com 785-727-1171
On Tue, Jul 7, 2015 at 10:44 PM, David Christensen <david@endpoint.com> wrote: > >> On Jul 7, 2015, at 3:53 AM, Fujii Masao <masao.fujii@gmail.com> wrote: >> >> On Tue, Jul 7, 2015 at 2:11 AM, David Christensen <david@endpoint.com> wrote: >>> Quickie patch for spotted missing psql \ddp tab-completion. >> >> Thanks for the report and patch! >> >> I found that tab-completion was not supported in not only \ddp >> but also other psql meta commands like \dE, \dm, \dO, \dy, \s and >> \setenv. Attached patch adds all those missing tab-completions. > > From a completeness standpoint makes sense to me to have all of them, but from a practical standpoint a single-charactercompletion like \s isn’t going to do much. :) Sometimes I type TAB after \ to display all the psql meta commands. Even single-character completion like \s may be useful for that case. Yeah, I agree that's narrow use case, though. Regards, -- Fujii Masao
On Tue, Jul 7, 2015 at 11:08 PM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Tue, Jul 7, 2015 at 10:44 PM, David Christensen <david@endpoint.com> wrote: >> >>> On Jul 7, 2015, at 3:53 AM, Fujii Masao <masao.fujii@gmail.com> wrote: >>> >>> On Tue, Jul 7, 2015 at 2:11 AM, David Christensen <david@endpoint.com> wrote: >>>> Quickie patch for spotted missing psql \ddp tab-completion. >>> >>> Thanks for the report and patch! >>> >>> I found that tab-completion was not supported in not only \ddp >>> but also other psql meta commands like \dE, \dm, \dO, \dy, \s and >>> \setenv. Attached patch adds all those missing tab-completions. Pushed. Regards, -- Fujii Masao
Fujii Masao wrote: > Sometimes I type TAB after \ to display all the psql meta commands. > Even single-character completion like \s may be useful for that case. > Yeah, I agree that's narrow use case, though. I agree that that's useful, so thanks for having pushed it. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services