Thread: pg_archivecleanup, and backup filename to specify as an argument
Hi, While I'm implementing the patch around pg_archivecleanup, I found the following warning about pg_archivecleanup in the document. Note that the .backup file name passed to the program should not include the extension. ISTM that pg_archivecleanup works as expected even if the .backup file with the extension is specified as follows. So, isn't this warning already obsolete? Or I'm missing something? $ pg_archivecleanup -d -x .zip myarchive 000000010000000000000009.00000028.backup.zip pg_archivecleanup: keep WAL file "myarchive/000000010000000000000009" and later pg_archivecleanup: removing file "myarchive/000000010000000000000005.zip" pg_archivecleanup: removing file "myarchive/000000010000000000000003.zip" pg_archivecleanup: removing file "myarchive/000000010000000000000001.zip" pg_archivecleanup: removing file "myarchive/000000010000000000000007.zip" pg_archivecleanup: removing file "myarchive/000000010000000000000006.zip" pg_archivecleanup: removing file "myarchive/000000010000000000000004.zip" pg_archivecleanup: removing file "myarchive/000000010000000000000002.zip" pg_archivecleanup: removing file "myarchive/000000010000000000000008.zip" Regards, -- Fujii Masao
On Thu, Jul 2, 2015 at 8:02 PM, Fujii Masao <masao.fujii@gmail.com> wrote: > Hi, > > While I'm implementing the patch around pg_archivecleanup, I found > the following warning about pg_archivecleanup in the document. > > Note that the .backup file name passed to the program should not > include the extension. > > ISTM that pg_archivecleanup works as expected even if the .backup file > with the extension is specified as follows. So, isn't this warning already > obsolete? Or I'm missing something? > > $ pg_archivecleanup -d -x .zip myarchive > 000000010000000000000009.00000028.backup.zip > pg_archivecleanup: keep WAL file "myarchive/000000010000000000000009" and later > pg_archivecleanup: removing file "myarchive/000000010000000000000005.zip" > pg_archivecleanup: removing file "myarchive/000000010000000000000003.zip" > pg_archivecleanup: removing file "myarchive/000000010000000000000001.zip" > pg_archivecleanup: removing file "myarchive/000000010000000000000007.zip" > pg_archivecleanup: removing file "myarchive/000000010000000000000006.zip" > pg_archivecleanup: removing file "myarchive/000000010000000000000004.zip" > pg_archivecleanup: removing file "myarchive/000000010000000000000002.zip" > pg_archivecleanup: removing file "myarchive/000000010000000000000008.zip" Even in 9.2 where -x option was added firstly, I confirmed that I could pass the .backup file name including the extension to pg_archivecleanup program. So I'm wondering if the warning in question was incorrect from the beginning... Or am I missing something? In the past thread of -x option patch, I found the following Robert comment. This makes me think that we unfortunately failed to notice his comment and finally added the unnecessary warning into the document. ----------------------------- http://www.postgresql.org/message-id/CA+TgmoZDYD_W7K_S1ZuEnqVNOaRWYCX=EETX+R27VB7akrrcEQ@mail.gmail.com Also, I'm wondering about this warning in the documentation: + extension added by the compression program. Note that the + <filename>.backup</> file name passed to the program should not + include the extension. IIUC, the latest change you made makes that warning obsolete, no? [rhaas pgsql]$ contrib/pg_archivecleanup/pg_archivecleanup -d -x .gz . 000000010000000000000010.00000020.backup.gz pg_archivecleanup: keep WAL file "./000000010000000000000010" and later ----------------------------- Regards, -- Fujii Masao
On Fri, Jul 3, 2015 at 9:56 PM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Thu, Jul 2, 2015 at 8:02 PM, Fujii Masao <masao.fujii@gmail.com> wrote: >> Hi, >> >> While I'm implementing the patch around pg_archivecleanup, I found >> the following warning about pg_archivecleanup in the document. >> >> Note that the .backup file name passed to the program should not >> include the extension. >> >> ISTM that pg_archivecleanup works as expected even if the .backup file >> with the extension is specified as follows. So, isn't this warning already >> obsolete? Or I'm missing something? >> >> $ pg_archivecleanup -d -x .zip myarchive >> 000000010000000000000009.00000028.backup.zip >> pg_archivecleanup: keep WAL file "myarchive/000000010000000000000009" and later >> pg_archivecleanup: removing file "myarchive/000000010000000000000005.zip" >> pg_archivecleanup: removing file "myarchive/000000010000000000000003.zip" >> pg_archivecleanup: removing file "myarchive/000000010000000000000001.zip" >> pg_archivecleanup: removing file "myarchive/000000010000000000000007.zip" >> pg_archivecleanup: removing file "myarchive/000000010000000000000006.zip" >> pg_archivecleanup: removing file "myarchive/000000010000000000000004.zip" >> pg_archivecleanup: removing file "myarchive/000000010000000000000002.zip" >> pg_archivecleanup: removing file "myarchive/000000010000000000000008.zip" > > Even in 9.2 where -x option was added firstly, I confirmed that > I could pass the .backup file name including the extension to > pg_archivecleanup program. So I'm wondering if the warning in > question was incorrect from the beginning... > Or am I missing something? > > In the past thread of -x option patch, I found the following > Robert comment. This makes me think that we unfortunately failed to > notice his comment and finally added the unnecessary warning into > the document. > > ----------------------------- > http://www.postgresql.org/message-id/CA+TgmoZDYD_W7K_S1ZuEnqVNOaRWYCX=EETX+R27VB7akrrcEQ@mail.gmail.com > Also, I'm wondering about this warning in the documentation: > > + extension added by the compression program. Note that the > + <filename>.backup</> file name passed to the program should not > + include the extension. > > IIUC, the latest change you made makes that warning obsolete, no? > > [rhaas pgsql]$ contrib/pg_archivecleanup/pg_archivecleanup -d -x .gz . > 000000010000000000000010.00000020.backup.gz > pg_archivecleanup: keep WAL file "./000000010000000000000010" and later > ----------------------------- Barring any objection, I will remove the warning from the document. Regards, -- Fujii Masao
On Mon, Jul 6, 2015 at 2:06 PM, Fujii Masao wrote: > Barring any objection, I will remove the warning from the document. Nuke it. -- Michael
On Mon, Jul 6, 2015 at 2:08 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Mon, Jul 6, 2015 at 2:06 PM, Fujii Masao wrote: >> Barring any objection, I will remove the warning from the document. > > Nuke it. Okay, done! Regards, -- Fujii Masao