Postgres Pro
Downloads
Home   >   mailing lists

Thread: Dead code in Create/RenameRole() after RoleSpec changes related to CURRENT/SESSION_USER

Dead code in Create/RenameRole() after RoleSpec changes related to CURRENT/SESSION_USER

From
Jeevan Chalke
Date:
Hi,

I found some dead code in CREATE/RENAME ROLE code path.
Attached patch to remove those.

We have introduced RoleSpec and handled public and none role names in grammar
itself. We do have these handling in CreateRole() and RenameRole() which is
NO more valid now.

Here is the related commit:
commit 31eae6028eca4365e7165f5f33fee1ed0486aee0
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:   Mon Mar 9 15:41:54 2015 -0300

    Allow CURRENT/SESSION_USER to be used in certain commands ...


Thanks

--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Attachment

Re: Dead code in Create/RenameRole() after RoleSpec changes related to CURRENT/SESSION_USER

From
Alvaro Herrera
Date:
Jeevan Chalke wrote:

> I found some dead code in CREATE/RENAME ROLE code path.
> 
> We have introduced RoleSpec and handled public and none role names in
> grammar
> itself. We do have these handling in CreateRole() and RenameRole()
> which is NO more valid now.

Right.


> Attached patch to remove those.

Pushed.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services