Thread: Missing "-i / --ignore-version" in pg_dump help

On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
> Hi all,
>
> There are some reason to "-i, --ignore-version" option doesn't appear in
> pg_dump help?

Because it's obsolete option, I think.

Regards,

--
Fujii Masao

<div dir="ltr"><div class="gmail_extra"><br />On Fri, May 22, 2015 at 9:20 AM, Fujii Masao <<a
href="mailto:masao.fujii@gmail.com">masao.fujii@gmail.com</a>>wrote:<br />><br />> On Fri, May 22, 2015 at
8:59PM, Fabrízio de Royes Mello<br />> <<a href="mailto:fabriziomello@gmail.com">fabriziomello@gmail.com</a>>
wrote:<br/>> > Hi all,<br />> ><br />> > There are some reason to "-i, --ignore-version" option
doesn'tappear in<br />> > pg_dump help?<br />><br />> Because it's obsolete option, I think.<br />><br
/><br/></div><div class="gmail_extra">You're correct... looking at the source code:<br /><br />  421             case
'i':<br/>  422                 /* ignored, deprecated option */<br />  423                 break;<br /><br /></div><div
class="gmail_extra">Thanks!<br/></div><div class="gmail_extra"><br />--<br />Fabrízio de Royes Mello<br
/>Consultoria/CoachingPostgreSQL<br />>> Timbira: <a
href="http://www.timbira.com.br">http://www.timbira.com.br</a><br/>>> Blog: <a
href="http://fabriziomello.github.io">http://fabriziomello.github.io</a><br/>>> Linkedin: <a
href="http://br.linkedin.com/in/fabriziomello">http://br.linkedin.com/in/fabriziomello</a><br/>>> Twitter: <a
href="http://twitter.com/fabriziomello">http://twitter.com/fabriziomello</a><br/>>> Github: <a
href="http://github.com/fabriziomello">http://github.com/fabriziomello</a></div></div>

Fujii Masao <masao.fujii@gmail.com> writes:
> On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello
> <fabriziomello@gmail.com> wrote:
>> There are some reason to "-i, --ignore-version" option doesn't appear in
>> pg_dump help?

> Because it's obsolete option, I think.

Yeah, see commit c22ed3d523782c43836c163c16fa5a7bb3912826.

Considering we shipped that in 8.4, maybe it's time to remove all
trace of those switches.  We'd still have to wait a couple releases
before it'd be safe to use -i for something else, but it'd be a start.
        regards, tom lane

On Fri, May 22, 2015 at 11:01 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fujii Masao <masao.fujii@gmail.com> writes:
>> On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello
>> <fabriziomello@gmail.com> wrote:
>>> There are some reason to "-i, --ignore-version" option doesn't appear in
>>> pg_dump help?
>
>> Because it's obsolete option, I think.
>
> Yeah, see commit c22ed3d523782c43836c163c16fa5a7bb3912826.
>
> Considering we shipped that in 8.4, maybe it's time to remove all
> trace of those switches.  We'd still have to wait a couple releases
> before it'd be safe to use -i for something else, but it'd be a start.

+1

Barring any objection, I will apply the attached patch and
remove that obsolete option..

Regards,

--
Fujii Masao

On Wed, Jun 3, 2015 at 1:53 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Fri, May 22, 2015 at 11:01 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Fujii Masao <masao.fujii@gmail.com> writes:
>>> On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello
>>> <fabriziomello@gmail.com> wrote:
>>>> There are some reason to "-i, --ignore-version" option doesn't appear in
>>>> pg_dump help?
>>
>>> Because it's obsolete option, I think.
>>
>> Yeah, see commit c22ed3d523782c43836c163c16fa5a7bb3912826.
>>
>> Considering we shipped that in 8.4, maybe it's time to remove all
>> trace of those switches.  We'd still have to wait a couple releases
>> before it'd be safe to use -i for something else, but it'd be a start.
>
> +1
>
> Barring any objection, I will apply the attached patch and
> remove that obsolete option..

Applied.

Regards,


--
Fujii Masao