Thread: Bringing text abbreviation debug output under the control of trace_sort
Attached patch makes trace_sort control abbreviation debug output for the text opclass, which makes it consistent with the numeric opclass. This seems better than relying on someone going to the trouble of building Postgres themselves to debug cases where abbreviation is the wrong thing, which we're not 100% sure will not occur. It also allows wider analysis of where abbreviation helps the most and the least in production, which is surely a good thing. I have added this to the next commitfest, but I suggest that it be quickly committed to the master branch as a maintenance commit. -- Peter Geoghegan
Attachment
On Sun, Apr 5, 2015 at 3:59 PM, Peter Geoghegan <pg@heroku.com> wrote: > Attached patch makes trace_sort control abbreviation debug output for > the text opclass, which makes it consistent with the numeric opclass. > This seems better than relying on someone going to the trouble of > building Postgres themselves to debug cases where abbreviation is the > wrong thing, which we're not 100% sure will not occur. It also allows > wider analysis of where abbreviation helps the most and the least in > production, which is surely a good thing. > > I have added this to the next commitfest, but I suggest that it be > quickly committed to the master branch as a maintenance commit. Done. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: Bringing text abbreviation debug output under the control of trace_sort
From
Peter Geoghegan
Date:
On Tue, Apr 7, 2015 at 7:46 PM, Robert Haas <robertmhaas@gmail.com> wrote: > Done. Thank you. -- Peter Geoghegan