Thread: Cygwin vs "win32" in configure
Buildfarm member brolga seems unhappy with my commit 91f4a5a that restricted port/dirmod.c to being built only on "Windows". Evidently we need to build it when $PORTNAME = "cygwin" as well, which is fine; but I'm a bit astonished that none of the other stuff inserted in the "# Win32 support" stanza beginning at configure.in line 1440 is needed for cygwin builds. Is that really correct, or am I misunderstanding what's happening here? regards, tom lane
Hi, On 2015-03-15 14:03:08 -0400, Tom Lane wrote: > Buildfarm member brolga seems unhappy with my commit 91f4a5a that > restricted port/dirmod.c to being built only on "Windows". Evidently > we need to build it when $PORTNAME = "cygwin" as well, which is fine; > but I'm a bit astonished that none of the other stuff inserted in the > "# Win32 support" stanza beginning at configure.in line 1440 is needed > for cygwin builds. Is that really correct, or am I misunderstanding > what's happening here? Those all sound like things that cygwin is going to emulate for us. I guess we could use more of those functions to reduce the difference, but I'm not sure it's worth it. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
On 03/15/2015 02:12 PM, Andres Freund wrote: > Hi, > > On 2015-03-15 14:03:08 -0400, Tom Lane wrote: >> Buildfarm member brolga seems unhappy with my commit 91f4a5a that >> restricted port/dirmod.c to being built only on "Windows". Evidently >> we need to build it when $PORTNAME = "cygwin" as well, which is fine; >> but I'm a bit astonished that none of the other stuff inserted in the >> "# Win32 support" stanza beginning at configure.in line 1440 is needed >> for cygwin builds. Is that really correct, or am I misunderstanding >> what's happening here? > Those all sound like things that cygwin is going to emulate for us. I > guess we could use more of those functions to reduce the difference, but > I'm not sure it's worth it. > I think that's right. cheers andrew