Thread: Compiler warning in master branch

Compiler warning in master branch

From
Peter Geoghegan
Date:
I see this when I build at -O2 from master's tip:

gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -fexcess-precision=standard -Werror -I../../../../src/include
-D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o
brin_revmap.o brin_revmap.c -MMD -MP -MF .deps/brin_revmap.Po
brin_revmap.c: In function ‘brinRevmapExtend’:
brin_revmap.c:113:14: error: variable ‘mapBlk’ set but not used
[-Werror=unused-but-set-variable] BlockNumber mapBlk;             ^

I'm using gcc 4.8.2 here.

--
Peter Geoghegan



Re: Compiler warning in master branch

From
David Rowley
Date:
On Mon, Nov 10, 2014 at 4:31 PM, Peter Geoghegan <pg@heroku.com> wrote:
I see this when I build at -O2 from master's tip:

gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -fexcess-precision=standard -Werror -I../../../../src/include
-D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o
brin_revmap.o brin_revmap.c -MMD -MP -MF .deps/brin_revmap.Po
brin_revmap.c: In function ‘brinRevmapExtend’:
brin_revmap.c:113:14: error: variable ‘mapBlk’ set but not used
[-Werror=unused-but-set-variable]
  BlockNumber mapBlk;
              ^

I'm using gcc 4.8.2 here.


It would appear just to need the attached.

Regards

David Rowley 
Attachment

Re: Compiler warning in master branch

From
Kevin Grittner
Date:
David Rowley <dgrowleyml@gmail.com> wrote:> On Mon, Nov 10, 2014 at 4:31 PM, Peter Geoghegan <pg@heroku.com> wrote:


>> I see this when I build at -O2 from master's tip:

>> brin_revmap.c: In function ‘brinRevmapExtend’:
>> brin_revmap.c:113:14: error: variable ‘mapBlk’ set but not used
>> [-Werror=unused-but-set-variable]
>>  BlockNumber mapBlk;
>>              ^

> It would appear just to need the attached.

Confirmed and pushed.

Thanks to both of you!

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company