Postgres Pro
Downloads
Home   >   mailing lists

Thread: Typos in comments

Typos in comments

From
Etsuro Fujita
Date:
I ran into a type " a a " in a comment in snapmgr.c, and found that
there are four other places that've made the same typo, by the grep
command.  And in one of those places, I found yet another typo.  Please
find attached a patch.

Thanks,

Best regards,
Etsuro Fujita
Attachment

Re: Typos in comments

From
David Rowley
Date:

On Mon, Oct 20, 2014 at 6:54 PM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote:
I ran into a type " a a " in a comment in snapmgr.c, and found that
there are four other places that've made the same typo, by the grep
command.  And in one of those places, I found yet another typo.  Please
find attached a patch.


Just while on this topic, I had a quick look at the results from the regex \b(\w+)\s+\1\b which finds duplicate words. After sifting through the false positives I found a few more. Patch attached.

Regards

David Rowley 
Attachment

Re: Typos in comments

From
Robert Haas
Date:
On Mon, Oct 20, 2014 at 3:04 AM, David Rowley <dgrowleyml@gmail.com> wrote:
> On Mon, Oct 20, 2014 at 6:54 PM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
> wrote:
>> I ran into a type " a a " in a comment in snapmgr.c, and found that
>> there are four other places that've made the same typo, by the grep
>> command.  And in one of those places, I found yet another typo.  Please
>> find attached a patch.
>
> Just while on this topic, I had a quick look at the results from the regex
> \b(\w+)\s+\1\b which finds duplicate words. After sifting through the false
> positives I found a few more. Patch attached.

Thanks.  I have committed both patches.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company