Thread: Re: Patch status: delta relations in AFTER triggers
On Wed, Aug 20, 2014 at 07:29:39AM -0700, Kevin Grittner wrote: > Heikki Linnakangas <hlinnakangas@vmware.com> wrote: > > > What's the status of the "delta relations in AFTER triggers" > > patch? I saw you had a lively discussion with Amit in the last > > two weeks, but I couldn't tell if it's still "Needs review" or > > should be "Waiting on Author" ? > > The patch that David offered to use the tuplestores in C should > probably be updated to show both direct use based on what is in > TriggerData and SPI use. I will leave that to David to submit;it > doesn't need to be in the same patch-set as the rest; it might, in > fact, be better to offer it separately once the API is solid (i.e., > after commit of the patch-sets I've just described.) I'd be happy to. Is there a repo I can refer to, or should I wait to start until those patch sets are submitted to -hackers? > Thanks for picking up the job of CF manager, BTW. It's a dirty > job, but somebody's got to do it. Indeed, and thanks for wrangling this, Heikki. Cheers, David. -- David Fetter <david@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
David Fetter <david@fetter.org> wrote: > On Wed, Aug 20, 2014 at 07:29:39AM -0700, Kevin Grittner wrote: >> The patch that David offered to use the tuplestores in C should >> probably be updated to show both direct use based on what is in >> TriggerData and SPI use. I will leave that to David to submit;it >> doesn't need to be in the same patch-set as the rest; it might, in >> fact, be better to offer it separately once the API is solid (i.e., >> after commit of the patch-sets I've just described.) > > I'd be happy to. Is there a repo I can refer to, or should I wait to > start until those patch sets are submitted to -hackers? It would be best to wait for the patches to be posted, or possibly for them to be committed. -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On Wed, Aug 20, 2014 at 09:59:11AM -0700, Kevin Grittner wrote: > David Fetter <david@fetter.org> wrote: > > On Wed, Aug 20, 2014 at 07:29:39AM -0700, Kevin Grittner wrote: > > >> The patch that David offered to use the tuplestores in C should > >> probably be updated to show both direct use based on what is in > >> TriggerData and SPI use. I will leave that to David to submit;it > >> doesn't need to be in the same patch-set as the rest; it might, > >> in fact, be better to offer it separately once the API is solid > >> (i.e., after commit of the patch-sets I've just described.) > > > > I'd be happy to. Is there a repo I can refer to, or should I wait > > to start until those patch sets are submitted to -hackers? > > It would be best to wait for the patches to be posted, or possibly > for them to be committed. Works for me. :) Cheers, David. -- David Fetter <david@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate